Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp795209ybf; Sat, 29 Feb 2020 16:26:22 -0800 (PST) X-Google-Smtp-Source: APXvYqzYWzCeU0W1qBapcq5Rmzh1hoeMb66XFxiXkMuCpF4S9cFsKPsF04M7aD+zpq1oDGghiBJu X-Received: by 2002:aca:db41:: with SMTP id s62mr7271872oig.87.1583022382610; Sat, 29 Feb 2020 16:26:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583022382; cv=none; d=google.com; s=arc-20160816; b=W9UykUa5pvDMb9uPng+c7CDL/cjvxZD1Z5+Qkj15DG5svRvdG5Oc0eNuOZvEItlHrz KOmVjT7kFYHyD0IMDlAW5zBfl8BsEZg/AsN/ZwZN8OePFY5sE76+GTP00qkkZaNndH30 FLCzn+DCpOgbt2MHyWXUeNaiPP1C5PEzSuaMAhP9a0NOZw3r93vry8+W2TRFUsbwAlzf ba+QH2dTRKU+p2uxWuOg8rZ70iHmFRpaLm+RPcxdDlezAeFUxXL/JCCja4RSHiN6leIW q7nY9Xddv3VrJArNRF3jTHp5alozg6n7qi85EoJ81/Qxt0D7D3ZBMADGHaEYMGe/jbtE kMLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=KSUPFY4YKPHtfhbvBecJ+RoZaFqx0nxoLw0ZMMdVTgw=; b=Wp3Ge2+sNAqoHzQmML+z62JNBCYwb2SqgEZJLc2wiBTxnFzjFo6xTGAVfytM/Qtm/y bCBdUGq/lAOXPX0Qe9mzhbk2cZmT6u2gpOJj14ak673ZELPFhY8xjSHbysBwhoi3YTIa Rnh1LLh4bI8EnDJJKWFZx8vhzdawxu1AXeIATyUsoemynII2mVtubfKYroV3NOmhVzrm KU1ze9FjwnqijmJ6o4g3dRALUD0OnjEeXghSILmIuljsQME8aakZ+UJ+JAZK8GkmkG+Z 57YNNy5AdSWUzOA3DacpvRX1+RLhj2N/XdUIbE6kQ9vGIa6kMKmJiQYwx876K1UncgUM gNbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j11si842089oiw.63.2020.02.29.16.26.10; Sat, 29 Feb 2020 16:26:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727276AbgCAAZ3 (ORCPT + 99 others); Sat, 29 Feb 2020 19:25:29 -0500 Received: from gloria.sntech.de ([185.11.138.130]:55690 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727120AbgCAAZ2 (ORCPT ); Sat, 29 Feb 2020 19:25:28 -0500 Received: from p508fcd9d.dip0.t-ipconnect.de ([80.143.205.157] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1j8CQ1-0004xy-6B; Sun, 01 Mar 2020 01:25:17 +0100 From: Heiko Stuebner To: Carlos de Paula Cc: papadakospan@gmail.com, jose.abreu@synopsys.com, Rob Herring , Mark Rutland , Robin Murphy , Jonas Karlman , Peter Geis , Katsuhiro Suzuki , Johan Jonker , Philipp Tomsich , Christoph Muellner , Enric Balletbo i Serra , Daniel Lezcano , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: rockchip: Add txpbl node for RK3399/RK3328 Date: Sun, 01 Mar 2020 01:25:16 +0100 Message-ID: <6132615.msM8OCcsVu@phil> In-Reply-To: <20200218221040.10955-1-me@carlosedp.com> References: <20200218221040.10955-1-me@carlosedp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 18. Februar 2020, 23:10:37 CET schrieb Carlos de Paula: > Some rockchip SoCs like the RK3399 and RK3328 exhibit an issue > where tx checksumming does not work with packets larger than 1498. > > The default Programmable Buffer Length for TX in these GMAC's is > not suitable for MTUs higher than 1498. The workaround is to disable > TX offloading with 'ethtool -K eth0 tx off rx off' causing performance > impacts as it disables hardware checksumming. > > This patch sets snps,txpbl to 0x4 which is a safe number tested ok for > the most popular MTU value of 1500. > > For reference, see https://lkml.org/lkml/2019/4/1/1382. > > Signed-off-by: Carlos de Paula applied for 5.7 Thanks Heiko