Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp951007ybf; Sat, 29 Feb 2020 20:41:52 -0800 (PST) X-Google-Smtp-Source: APXvYqwh8ZTDSzdq9X/B5lSvdFmIpQdjtu1SHFEmMWNRRXjxXzedG3z4ez9pQ1vAzALM7k+FUFtk X-Received: by 2002:a05:6830:1304:: with SMTP id p4mr9111823otq.327.1583037712824; Sat, 29 Feb 2020 20:41:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583037712; cv=none; d=google.com; s=arc-20160816; b=i4jy9ZDjXAIS5DMqn6K8aS9ZemsRJJ+qK7YYXqZzBil5J3Mg8GCFz6dW4SBiWny0HY w974G6IcNAfsrs2DPT9aihgYIgmVSs+D4MvUDdZKA1DbppiIKXhA4zZRm693L0SNtUJr otDOABLsZjo6ba59ynSEhcw2yjZZZV1oKT+bjDy9Y05daQD8PXZQrnJdRZNj8PF4Mqz0 mXDz21cZEMR3ZZlw9w0T9ZplV0Pj2hL0JUFvbj195+ihdBtH2T5lQ1TPsJv3IW0uIi9y surc4FMggzCoCbeAvy3azMuKdZ7PB/e1IkQ2olCkMUTco2aej0ZEp5TaYPm0OWspQdAV IDPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=uqB0siGakmxXOpMIaZrg1eFZI/D58ZvVdWeokvKsNIU=; b=YUuOmOnzyEar1/OML5fHKAqs7GgYFGc7Zjmu5EBXCDQa5ZntTUF2KecqqnwuE/utxo bRaZJUQlvXIgnBP89PQzan+QYoYwz+yRCVAMlSUD+wCJUEo+dBrn9f5o9IenJpDaOYyY ZLaZDGpbPt8x7yQRcWIoNQWEwhpwXk42VenZBR8iuuAc4jo16Mg96XcZ2t9RfwiDrA5j AHw4bSqv70okFVJVBJyE9dJ6eqIkM/2eljDEid1qL4Jix4krnCNhhgPc4U4AtNdEb9er 5CmUoIKmR9v3M0JrgVt1wyW+ckzHyZu4iOcXdmlxORqZlJanMvZVXSU9XaFfRLetREHq RjPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kOBtoWw+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m9si3818729oie.148.2020.02.29.20.41.10; Sat, 29 Feb 2020 20:41:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kOBtoWw+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726805AbgCAEkB (ORCPT + 99 others); Sat, 29 Feb 2020 23:40:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:46906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726151AbgCAEkB (ORCPT ); Sat, 29 Feb 2020 23:40:01 -0500 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E9A721744; Sun, 1 Mar 2020 04:40:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583037600; bh=gobused7njiojKjjqHPxsxE2sYg6sCzrDITBeT2chUU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kOBtoWw+pxLOXT1F1ojHWEG/BsRFH4DkCpCzD+woTNzE3ZsGY0Gtfdg9TG7vGfEJF P6jY+hSeTZ3Gx/tEdeUBTasBiKIk50O2k6Wj5l4qcb3G+UTR0rvclOL+qgUqj632xi HIBld3Epnf9/SaD3mBpezZ+KO9z5jWmTMcCceAng= Date: Sat, 29 Feb 2020 20:40:00 -0800 From: Andrew Morton To: Joonsoo Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Hugh Dickins , Minchan Kim , Vlastimil Babka , Mel Gorman , kernel-team@lge.com Subject: Re: [PATCH v2 0/9] workingset protection/detection on the anonymous LRU list Message-Id: <20200229204000.298de32521885b8af858a50d@linux-foundation.org> In-Reply-To: <20200227074748.GA18113@js1304-desktop> References: <1582175513-22601-1-git-send-email-iamjoonsoo.kim@lge.com> <20200226193942.30049da9c090b466bdc5ec23@linux-foundation.org> <20200227074748.GA18113@js1304-desktop> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Feb 2020 16:48:47 +0900 Joonsoo Kim wrote: > Hello, Andrew. > > > > * SOLUTION > > > Since this is what we want to avoid, this patchset implements workingset > > > protection. Like as the file LRU list, newly created or swap-in anonymous > > > page is started on the inactive list. Also, like as the file LRU list, > > > if enough reference happens, the page will be promoted. This simple > > > modification changes the above example as following. > > > > One wonders why on earth we weren't doing these things in the first > > place? > > I don't know. I tried to find the origin of this behaviour and found > that it's from you 18 years ago. :) > > It mentions that starting pages on the active list boosts throughput on > stupid swapstormy test but I cannot guess the exact reason of such > improvement. > > Anyway, Following is the related patch history. Could you remember > anything about it? > erm, yes, that was a long time ago ;) I guess enough other things have changed since then to necessitate a revisit!