Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1136024ybf; Sun, 1 Mar 2020 01:42:10 -0800 (PST) X-Google-Smtp-Source: APXvYqygCkT6p32Me9CZINdWWWPTmQICcP1T7lsPF58aXUbEi7tMmfojf0i8A+yJkSkA3RkURqdS X-Received: by 2002:aca:ed04:: with SMTP id l4mr8541807oih.54.1583055730689; Sun, 01 Mar 2020 01:42:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583055730; cv=none; d=google.com; s=arc-20160816; b=Cb0E6ZeZduA/Tdby7FndpXFam8EIxjKQv6V9o7Se+7Uv7cWNyhOHM4c2B2/2SvxRAf JsmWPUeguHz5Et7IZHvG/r9tmhfHsfKjq1g3zFlZ/BcoYhSllrpH5hqrmcOJqc9e7mca LyvtYtFVuMxJEpyLyHLLdAZJnz0nkMkkDG/f60U5za/xXIZ05ZlTA7wWd436g6xgYLhj Yt90P7kodAOwGqhvm5hl3MtAydXZlrSAG4pu9bePnP0ZKYwlJXfB1yQ3Pj4g7YeSMAKk Yv9lemc9f48w95o2vPMiVDqjzv73c3ToVIj0aWmnsS/hrhVLENKejnHZkwOHg561Vez1 FiUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=YCIInhsfSvrFwl+wyf35RV6gXFlFKhPcV30u1+vysdo=; b=wwwgXzfaQURpViTixGjKZVaNjnA5SaOoJcoVOfqofkk00RcSPC3gvEke/BFnnRo2Ez kUSo0kTRJqosavftdCsrQ+GuYU20vptVcHlY7iZJCDgFmYiUw9i7arUhq6fZorxsYC+h Ksn1XCt/hWWP3IYRv50KomwehplawWexmyS2Ke/XPBh9blB7h5cdiNb0z1DN4NXEHFje ruPeEc5ZhQ++9a08FhlSpoLXtN2GvzDS3roNwQY2FA+rooJG2CaFO4q2GqA6XEOKFELh Xhh7rTP4Ju8+0qP8jIp3RJ971RbBh7H7beN5aefEF6IeVnY5nQrWKufi0tJWIjrKxE5H J9Cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z10si3867037oix.235.2020.03.01.01.41.59; Sun, 01 Mar 2020 01:42:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726621AbgCAJlt (ORCPT + 99 others); Sun, 1 Mar 2020 04:41:49 -0500 Received: from 212.199.177.27.static.012.net.il ([212.199.177.27]:38434 "EHLO herzl.nuvoton.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726167AbgCAJls (ORCPT ); Sun, 1 Mar 2020 04:41:48 -0500 Received: from taln60.nuvoton.co.il (ntil-fw [212.199.177.25]) by herzl.nuvoton.co.il (8.13.8/8.13.8) with ESMTP id 0219ej21028757; Sun, 1 Mar 2020 11:40:45 +0200 Received: by taln60.nuvoton.co.il (Postfix, from userid 10070) id B468E6032E; Sun, 1 Mar 2020 11:40:45 +0200 (IST) From: Tomer Maimon To: wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org, mark.rutland@arm.com, joel@jms.id.au, avifishman70@gmail.com, tali.perry1@gmail.com, yuenn@google.com, benjaminfair@google.com Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Tomer Maimon Subject: [PATCH v1 4/4] watchdog: npcm: sets card ext1 and ext2 bootstatus during probe Date: Sun, 1 Mar 2020 11:40:40 +0200 Message-Id: <20200301094040.123189-5-tmaimon77@gmail.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20200301094040.123189-1-tmaimon77@gmail.com> References: <20200301094040.123189-1-tmaimon77@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During probe NPCM watchdog sets the following bootstatus flags: - WDIOF_CARDRESET represent power and core reset. - WDIOF_EXTERN1 represent watchdog 0-2 reset. - WDIOF_EXTERN2 represent software 1-4 reset. Each flag is representing a group of bootstatus. The user can configure through the device treethe exact reset to each flag group. Signed-off-by: Tomer Maimon --- drivers/watchdog/npcm_wdt.c | 132 ++++++++++++++++++++++++++++++++---- 1 file changed, 119 insertions(+), 13 deletions(-) diff --git a/drivers/watchdog/npcm_wdt.c b/drivers/watchdog/npcm_wdt.c index 8609c7acf17d..dba9a73249c9 100644 --- a/drivers/watchdog/npcm_wdt.c +++ b/drivers/watchdog/npcm_wdt.c @@ -11,7 +11,24 @@ #include #include #include - +#include +#include + +/* NPCM7xx GCR module */ +#define NPCM7XX_RESSR_OFFSET 0x6C +#define NPCM7XX_INTCR2_OFFSET 0x60 + +#define NPCM7XX_PORST BIT(31) +#define NPCM7XX_CORST BIT(30) +#define NPCM7XX_WD0RST BIT(29) +#define NPCM7XX_WD1RST BIT(24) +#define NPCM7XX_WD2RST BIT(23) +#define NPCM7XX_SWR1RST BIT(28) +#define NPCM7XX_SWR2RST BIT(27) +#define NPCM7XX_SWR3RST BIT(26) +#define NPCM7XX_SWR4RST BIT(25) + + /* WD register */ #define NPCM_WTCR 0x1C #define NPCM_WTCLK (BIT(10) | BIT(11)) /* Clock divider */ @@ -43,6 +60,9 @@ struct npcm_wdt { struct watchdog_device wdd; void __iomem *reg; + u32 card_reset; + u32 ext1_reset; + u32 ext2_reset; }; static inline struct npcm_wdt *to_npcm_wdt(struct watchdog_device *wdd) @@ -103,30 +123,29 @@ static int npcm_wdt_stop(struct watchdog_device *wdd) return 0; } - static int npcm_wdt_set_timeout(struct watchdog_device *wdd, unsigned int timeout) { if (timeout < 2) wdd->timeout = 1; else if (timeout < 3) - wdd->timeout = 2; + wdd->timeout = 2; else if (timeout < 6) - wdd->timeout = 5; + wdd->timeout = 5; else if (timeout < 11) - wdd->timeout = 10; + wdd->timeout = 10; else if (timeout < 22) - wdd->timeout = 21; + wdd->timeout = 21; else if (timeout < 44) - wdd->timeout = 43; + wdd->timeout = 43; else if (timeout < 87) - wdd->timeout = 86; + wdd->timeout = 86; else if (timeout < 173) - wdd->timeout = 172; + wdd->timeout = 172; else if (timeout < 688) - wdd->timeout = 687; + wdd->timeout = 687; else - wdd->timeout = 2750; + wdd->timeout = 2750; if (watchdog_active(wdd)) npcm_wdt_start(wdd); @@ -177,9 +196,61 @@ static const struct watchdog_ops npcm_wdt_ops = { .restart = npcm_wdt_restart, }; +static void npcm_get_reset_status(struct npcm_wdt *wdt, struct device *dev) +{ + struct regmap *gcr_regmap; + u32 rstval; + + if (of_device_is_compatible(dev->of_node, "nuvoton,npcm750-wdt")) { + gcr_regmap = syscon_regmap_lookup_by_compatible("nuvoton,npcm750-gcr"); + if (IS_ERR(gcr_regmap)) + dev_warn(dev, "Failed to find nuvoton,npcm750-gcr WD reset status not supported\n"); + + regmap_read(gcr_regmap, NPCM7XX_RESSR_OFFSET, &rstval); + if (!rstval) { + regmap_read(gcr_regmap, NPCM7XX_INTCR2_OFFSET, &rstval); + rstval = ~rstval; + } + + if (rstval & wdt->card_reset) + wdt->wdd.bootstatus |= WDIOF_CARDRESET; + if (rstval & wdt->ext1_reset) + wdt->wdd.bootstatus |= WDIOF_EXTERN1; + if (rstval & wdt->ext2_reset) + wdt->wdd.bootstatus |= WDIOF_EXTERN2; + } +} + +static u32 npcm_wdt_reset_type(const char *reset_type) +{ + if (!strcmp(reset_type, "porst")) + return NPCM7XX_PORST; + else if (!strcmp(reset_type, "corst")) + return NPCM7XX_CORST; + else if (!strcmp(reset_type, "wd0")) + return NPCM7XX_WD0RST; + else if (!strcmp(reset_type, "wd1")) + return NPCM7XX_WD1RST; + else if (!strcmp(reset_type, "wd2")) + return NPCM7XX_WD2RST; + else if (!strcmp(reset_type, "sw1")) + return NPCM7XX_SWR1RST; + else if (!strcmp(reset_type, "sw2")) + return NPCM7XX_SWR2RST; + else if (!strcmp(reset_type, "sw3")) + return NPCM7XX_SWR3RST; + else if (!strcmp(reset_type, "sw4")) + return NPCM7XX_SWR4RST; + + return 0; +} + static int npcm_wdt_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; + const char *card_reset_type; + const char *ext1_reset_type; + const char *ext2_reset_type; struct npcm_wdt *wdt; u32 priority; int irq; @@ -202,6 +273,39 @@ static int npcm_wdt_probe(struct platform_device *pdev) else watchdog_set_restart_priority(&wdt->wdd, priority); + ret = of_property_read_string(pdev->dev.of_node, + "nuvoton,card-reset-type", + &card_reset_type); + if (ret) { + wdt->card_reset = NPCM7XX_PORST; + } else { + wdt->card_reset = npcm_wdt_reset_type(card_reset_type); + if (!wdt->card_reset) + wdt->card_reset = NPCM7XX_PORST; + } + + ret = of_property_read_string(pdev->dev.of_node, + "nuvoton,ext1-reset-type", + &ext1_reset_type); + if (ret) { + wdt->ext1_reset = NPCM7XX_WD0RST; + } else { + wdt->ext1_reset = npcm_wdt_reset_type(ext1_reset_type); + if (!wdt->ext1_reset) + wdt->ext1_reset = NPCM7XX_WD0RST; + } + + ret = of_property_read_string(pdev->dev.of_node, + "nuvoton,ext2-reset-type", + &ext2_reset_type); + if (ret) { + wdt->ext2_reset = NPCM7XX_SWR1RST; + } else { + wdt->ext2_reset = npcm_wdt_reset_type(ext2_reset_type); + if (!wdt->ext2_reset) + wdt->ext2_reset = NPCM7XX_SWR1RST; + } + wdt->wdd.info = &npcm_wdt_info; wdt->wdd.ops = &npcm_wdt_ops; wdt->wdd.min_timeout = 1; @@ -220,8 +324,10 @@ static int npcm_wdt_probe(struct platform_device *pdev) set_bit(WDOG_HW_RUNNING, &wdt->wdd.status); } - ret = devm_request_irq(dev, irq, npcm_wdt_interrupt, 0, "watchdog", - wdt); + npcm_get_reset_status(wdt, dev); + + ret = devm_request_irq(dev, irq, npcm_wdt_interrupt, 0, + "watchdog", wdt); if (ret) return ret; -- 2.22.0