Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200301110733.20197-1-yuri.benditovich@daynix.com> <20200301063121-mutt-send-email-mst@kernel.org>
In-Reply-To: <20200301063121-mutt-send-email-mst@kernel.org>
From:   Yuri Benditovich <yuri.benditovich@daynix.com>
Date:   Sun, 1 Mar 2020 14:47:41 +0200
Message-ID: <CAOEp5Ofzz2CrkbBoPsOAGDVdVJZ07nzH0Usv5h6a96p8+YknwA@mail.gmail.com>
Subject: Re: [PATCH v2 0/3] virtio-net: introduce features defined in the spec
To:     "Michael S. Tsirkin" <mst@redhat.com>
Cc:     Jason Wang <jasowang@redhat.com>,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, Yan Vugenfirer <yan@daynix.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Mar 1, 2020 at 1:32 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Sun, Mar 01, 2020 at 01:07:30PM +0200, Yuri Benditovich wrote:
> > This series introduce virtio-net features VIRTIO_NET_F_RSC_EXT,
> > VIRTIO_NET_F_RSS and VIRTIO_NET_F_HASH_REPORT.
> >
> > Changes from v1:
> > __virtio -> __le
> > maximal -> maximum
> > minor style fixes
>
>
> Looks good to me - sent a bit of consmetics.
>
> But as any virtio UAPI change, please CC virtio-dev as virtio TC maintains the
> interface. Thanks!

Probably 'virtio-dev' should be added to maintainers file.

>
> > Yuri Benditovich (3):
> >   virtio-net: Introduce extended RSC feature
> >   virtio-net: Introduce RSS receive steering feature
> >   virtio-net: Introduce hash report feature
> >
> >  include/uapi/linux/virtio_net.h | 90 +++++++++++++++++++++++++++++++--
> >  1 file changed, 86 insertions(+), 4 deletions(-)
> >
> > --
> > 2.17.1
>