Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1361336ybf; Sun, 1 Mar 2020 07:31:27 -0800 (PST) X-Google-Smtp-Source: APXvYqzAO53BVfz/qD2+yhY9SI0tUofGMHFSrELwD6kSUrDNYPWkWHzmwbJI6draSHT7X0Hihuo4 X-Received: by 2002:aca:3189:: with SMTP id x131mr9126386oix.33.1583076687238; Sun, 01 Mar 2020 07:31:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583076687; cv=none; d=google.com; s=arc-20160816; b=thganpPnOqkb1YURWEhJkcIUfrTEGFytf0EjUW54g6/1O/pazgEPw0FMf7lmrPSSm8 pZD19sbamTDibD9pSH7aiclfCrbMLqpFO8e8WlEEsF6FW8afGx6Uot8r3xlcVzuSmXP+ NoNGqHRgdRwXotZDAcEQDyKAFOgYzfIyRJdhrI+yZF+c5eS845717P1h9LoDSVtaUrxC QjP51NjK1Zz6AInLXfz8AZiFVn9Bze3cDTjWEm5vAuWNECoExJ9Q95RxcIYb6pBiD8DB 7iwlwuPcZxGttzstzx7olHKPMII5FPv3FsMzNMql5GbusH5Yk8dvPakZSgP1RfujIinT nPKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=ubSe/iv847hRz3go2vcVkh5paHl2lJ7NU6C3tPrE1OQ=; b=YmO9rK+ek1l2JvwEVa4QDgfsv1b1E16CqQnzzv/d8JSrh8rRGYiZcplOpU9WNAaf30 9h/wYVcmelIv9rbY8KJS7la3mnWGbro0D8c0rYINHiFfV9rwwsX7CPTOv3djtf2VkHBc 4dUMmzOAsj8y0CCv8lZGN83h2JrzBuglAZutb3pebIy4SQSReKXoqX5+AqiIsH5PwVvH zk7PuHY6ZtO9gfhOkBlW4HnuH2wb7nOeTs3punwtnBB3jnc0Gs4kKb572fKBCJjj37q5 6ZWllDY94XEPYnSL67sskHkP2GxcAy6BqP+KYQxg+eXQzbdjiRY08TnPBA8dtiWbbNy1 T40A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=R4niIOWr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l13si4928993otq.30.2020.03.01.07.31.12; Sun, 01 Mar 2020 07:31:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=R4niIOWr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726366AbgCAPaf (ORCPT + 99 others); Sun, 1 Mar 2020 10:30:35 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:44362 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726094AbgCAPaf (ORCPT ); Sun, 1 Mar 2020 10:30:35 -0500 Received: by mail-lj1-f194.google.com with SMTP id a10so763859ljp.11 for ; Sun, 01 Mar 2020 07:30:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ubSe/iv847hRz3go2vcVkh5paHl2lJ7NU6C3tPrE1OQ=; b=R4niIOWre5oK0ZblTbLQzhTKf17NjJYu1fAvKbO8W+aBE05PXMYfrEKaT0rSMHY7mP A8Z1vGVG4MLqLJ+GohxngccxJQLR+wwr22XkTZJrQUEDLenEivFQFgcv7rNnkHLwchr5 AtX/ZC+8Bm1QhBzIK+3aUg/4R/HweizU3kms3QlY1/W2tpWdyenNe+2gS7R+1OelNGKV X7g0gS3F9a8J775AiIRhDpBbPyoLHtlY9tC+a7xRAmHuhnTnSfp6N8elggF0mDL7kv5n kBWj0cvjyRFtl4Bi5jfIhzwiBQgtlPumWEpdUNJQQEzgLbJnMZ+OnffdGrbObGQSJ66l V5gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ubSe/iv847hRz3go2vcVkh5paHl2lJ7NU6C3tPrE1OQ=; b=fbwizGrd99iXS+Ujt+98rxINwlbCu/Szt35kR1nZYaBlHPsnpkv+nlXDngVw/GKwRd HVEcx/ZQl2x6k5Uve7wV9t4yQJQh1pelVE9bBadJSRd1oIqKQwncK8UWW3zgVX+JGPEe xMC7N7smSccD/o60zRCxU9/IsKad+TSi9PWdI1RyxGnWF7nVR32pQfC6klWqzWAIS01P jLzcBQi23943kpb2tr8zRJc1CRyCSpS5OSuqox0H4r/MKP5kXARo0dUEmVzjDcG0pq9S RpOnvPvKOiWQKqQZSnoCGJEjCc8BoivEofyK7kp8nflh70bpCOySPBKnhdbJe8pc2t89 kOQA== X-Gm-Message-State: ANhLgQ0yz5K1wc6CT2huIJVGJEcVF1pTmJ3VyuKxtQWrotNxXqrnOVYU K1ffyPNfHqS7e65g+iFg2Wk= X-Received: by 2002:a2e:3214:: with SMTP id y20mr8735810ljy.69.1583076633263; Sun, 01 Mar 2020 07:30:33 -0800 (PST) Received: from localhost.localdomain (188.146.100.83.nat.umts.dynamic.t-mobile.pl. [188.146.100.83]) by smtp.gmail.com with ESMTPSA id g21sm9876384ljj.53.2020.03.01.07.30.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2020 07:30:32 -0800 (PST) From: mateusznosek0@gmail.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Mateusz Nosek , hughd@google.com, akpm@linux-foundation.org Subject: [PATCH] mm/shmem.c: Clean code by removing unnecessary assignment Date: Sun, 1 Mar 2020 16:28:32 +0100 Message-Id: <20200301152832.24595-1-mateusznosek0@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mateusz Nosek Previously 0 was assigned to variable 'error' but the variable was never read before reassignemnt later. So the assignment can be removed. Signed-off-by: Mateusz Nosek --- mm/shmem.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 31b4bcc95f17..84eb14f5509c 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -3116,12 +3116,9 @@ static int shmem_symlink(struct inode *dir, struct dentry *dentry, const char *s error = security_inode_init_security(inode, dir, &dentry->d_name, shmem_initxattrs, NULL); - if (error) { - if (error != -EOPNOTSUPP) { - iput(inode); - return error; - } - error = 0; + if (error && error != -EOPNOTSUPP) { + iput(inode); + return error; } inode->i_size = len-1; -- 2.17.1