Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 1 Mar 2020 15:50:48 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Sergiu Cuciurean <sergiu.cuciurean@analog.com>
Cc:     <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <knaack.h@gmx.de>, <lars@metafoo.de>,
        <pmeerw@pmeerw.net>, <info@metux.net>, <lukas@wunner.de>,
        <tglx@linutronix.de>
Subject: Re: [PATCH] iio: adc: mcp320x: Use new structure for SPI transfer
 delays
Message-ID: <20200301155048.76223dfc@archlinux>
In-Reply-To: <20200227122940.18243-1-sergiu.cuciurean@analog.com>
References: <20200227122940.18243-1-sergiu.cuciurean@analog.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 27 Feb 2020 14:29:40 +0200
Sergiu Cuciurean <sergiu.cuciurean@analog.com> wrote:

> In a recent change to the SPI subsystem [1], a new `delay` struct was added
> to replace the `delay_usecs`. This change replaces the current
> `delay_usecs` with `delay` for this driver.
> 
> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
> that both `delay_usecs` & `delay` are used (in this order to preserve
> backwards compatibility).
> 
> [1] commit bebcfd272df6 ("spi: introduce `delay` field for
> `spi_transfer` + spi_transfer_delay_exec()")
> 
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to poke at it.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/mcp320x.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
> index 465c7625a55a..2c0eb5de110c 100644
> --- a/drivers/iio/adc/mcp320x.c
> +++ b/drivers/iio/adc/mcp320x.c
> @@ -421,7 +421,8 @@ static int mcp320x_probe(struct spi_device *spi)
>  			adc->transfer[1].len++;
>  
>  		/* conversions are started by asserting CS pin for 8 usec */
> -		adc->start_conv_transfer.delay_usecs = 8;
> +		adc->start_conv_transfer.delay.value = 8;
> +		adc->start_conv_transfer.delay.unit = SPI_DELAY_UNIT_USECS;
>  		spi_message_init_with_transfers(&adc->start_conv_msg,
>  						&adc->start_conv_transfer, 1);
>