Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1418660ybf;
        Sun, 1 Mar 2020 08:55:45 -0800 (PST)
X-Google-Smtp-Source: APXvYqwBoBLwVj+d7+9SeS/buedmrik09Wm10jXtwcTY/tZVDvgXqek4yqFG9G0kf3vBHT1FHnid
X-Received: by 2002:a54:458d:: with SMTP id z13mr9344544oib.32.1583081745761;
        Sun, 01 Mar 2020 08:55:45 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1583081745; cv=none;
        d=google.com; s=arc-20160816;
        b=hdFqd0dZaIkJ/wBhO2nE0utRtJ5/84IlEW33FInAPvwVFmV2EovwTrwmDlNrX91N8F
         My6a50vIH4brqEHLADyCX30Fup28tP11j6iUbVoyIiu885mqVPgmtFTUAnnew+u16WmJ
         4MNdziA8dRBrhJs/5UwkU4K+HXT157v0/OFTNmQpxji9JsnerU48Pd8WnsQwUQBRORou
         ru3sdfVoDi1kSXzsB5Hqqhdn749+B83xNYRKaj7V8sF5IRCVYjT7ZV62aqTPrOb9FPRP
         PeL8mgwM9SXTN8RQ/+vtNqoWLObkbS88lR+nh6kFcVPHX0ZOU09E+n83wH79XAIikSza
         IbWw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=SnbXFd/E25ngDXXq5Lh/mAWbnynYG5+//K6zA7Uakz8=;
        b=1CVmoiG9xzm14ceJqAhMcabr9m/a91J1r76ByXvynp0fLZvYyY3YxzafJEQczK3tfC
         2fIzGAdKknppmwAHSWHQccv84h0AsV9/IgSvbizxSS19VNo3JZYbaRme7jk6Wlror4Zn
         sFK5AK7asKlBVqL5anZfci9kUhRjniRmAX8vvCwrKl1aZRfeMGGjXpHir7PiYDWTqUfN
         Rxo/pBSZ1iv3895CTpAc7k66V9p5nFMSDQSMtJPMCpxEHe8qYEbOCvuhjKs9uwcL7N3w
         Ly5lLJ2wonjJVpFGqC+4iRgnAOC8IY5Ht+pTblbDcqeFT8bYM4+hXqPvraHim+92X8xU
         KsXw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=NPuewaH3;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id z18si4948921oid.82.2020.03.01.08.55.33;
        Sun, 01 Mar 2020 08:55:45 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=NPuewaH3;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726465AbgCAQzB (ORCPT <rfc822;rruigrok1@gmail.com> + 99 others);
        Sun, 1 Mar 2020 11:55:01 -0500
Received: from bombadil.infradead.org ([198.137.202.133]:50530 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726204AbgCAQzB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 1 Mar 2020 11:55:01 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=SnbXFd/E25ngDXXq5Lh/mAWbnynYG5+//K6zA7Uakz8=; b=NPuewaH3yDoNoouMAO77qdaY+D
        58SP3KlQZ4C2cCoslqotXrH8YGgI9uJ+IGwr86EwTw34fV5Q3cSHgGQIskSVL1IdiNjOuNDC64Htl
        +cD2Vaidt3qp1Ec1wNhB9e8Re961EtF1GQCPWmsE2BjNfupYG7OhAdjKC0ByK2CiAx1AvtULA7sdk
        UL34EFVmXMaZvEH073NLdP4Mo/TNpM79vojN8tX8UBKw0OfEadHKsKwAYPK22sYVoUkCfi8A4MFzn
        Yal4CYO86hFHWq1nDoCtAwsV9n+HsKikghjvILsL6ICQNeFr9gsus7qKvKfZUU44yYtkgxA84XFxW
        AgIaMqqw==;
Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux))
        id 1j8Rrm-0001qB-Io; Sun, 01 Mar 2020 16:54:58 +0000
Date:   Sun, 1 Mar 2020 08:54:58 -0800
From:   Matthew Wilcox <willy@infradead.org>
To:     mateusznosek0@gmail.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org, hughd@google.com,
        akpm@linux-foundation.org
Subject: Re: [PATCH] mm/shmem.c: Clean code by removing unnecessary assignment
Message-ID: <20200301165458.GO29971@bombadil.infradead.org>
References: <20200301152832.24595-1-mateusznosek0@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200301152832.24595-1-mateusznosek0@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Mar 01, 2020 at 04:28:32PM +0100, mateusznosek0@gmail.com wrote:
> Previously 0 was assigned to variable 'error'
> but the variable was never read before reassignemnt later.
> So the assignment can be removed.

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>