Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp1599063ybf; Sun, 1 Mar 2020 13:21:06 -0800 (PST) X-Google-Smtp-Source: APXvYqwSUiRC1qLFXaLMpOR9PiQQhdG9SudF2K80pOY8Klsf56b1KbzoddBcoC0fvBzVYb0y2rFR X-Received: by 2002:a54:458d:: with SMTP id z13mr9850143oib.32.1583097666192; Sun, 01 Mar 2020 13:21:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583097666; cv=none; d=google.com; s=arc-20160816; b=sOJlHfxjNGtjQdHyoIz47y1ZKDQ+CGOQMOGhr48MAGZP7jSs2rvddv1q1Ao/Fl5jqQ 5OIgmTNFvPoxZrUuv1f+mZKGWU43oizR7vc0yUXB5d3cO0ccfo0z7YkCzdiTnWuELsjU T8JmMX8VJeg6jJ8YDlSgfExKKSojE/hHQ5zlALx044CIe43dNGEMQzEwsEE2yh7ZzqSD Uxe56jogO3UO7jF5twDhPvl2Yvw2dH0eUhshna8SUcQKJJQZd/JVH2BykcUK9o5BsG5c nX7QLsvNlA80eQvJGXP8JIRmpef1qw/79oKQvdrCZEjUh8OVyJVUyr9xIbE3/iPbum1E e6vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ZzomB/z5G+3VO1dZoUUjijRsXrGG3pSCqf1Krfmwrc0=; b=tM2PPC4OdCzCwbTEY0A2nNmgrMUhy2Uh8cSP4q9ejxxBJhkhn58jqIQStBuZQ1lTap W1oHpvV+qFt0LF1oJrx4v6CMZpmp9tcdO+TLBolPN+qeSOio+osCyCQkN59wRMxxApGi 6RNf7+osXGBwJCR19XHJh7Lr8Xg25WQbsGnS0D54xwvkRbKyhfRcTaNMW8nZskkoKqz+ Fn2+DOFXCF2X4z/OAo5aTgyHbKDmXQAR4V8TgISHqcqhpZAu1g/NUVsgufJYtLRpvCSY P5yq7SRH53bs+hftBWtOKNXVbGOuz/q9O2wHv7VT0XOj6/+rMSy5p01cRXAJygSnukzF YO3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si5619497oib.193.2020.03.01.13.20.38; Sun, 01 Mar 2020 13:21:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726536AbgCAVUe (ORCPT + 99 others); Sun, 1 Mar 2020 16:20:34 -0500 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:32100 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726366AbgCAVUd (ORCPT ); Sun, 1 Mar 2020 16:20:33 -0500 Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 021LKNLR011368; Sun, 1 Mar 2020 22:20:23 +0100 Date: Sun, 1 Mar 2020 22:20:23 +0100 From: Willy Tarreau To: Joe Perches Cc: Denis Efremov , Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH v2 0/6] floppy: make use of the local/global fdc explicit Message-ID: <20200301212023.GA11317@1wt.eu> References: <20200301195555.11154-1-w@1wt.eu> <03a2ea0b91ab61ba9a11230e82f1fb3bdf420a50.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <03a2ea0b91ab61ba9a11230e82f1fb3bdf420a50.camel@perches.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 01, 2020 at 12:33:25PM -0800, Joe Perches wrote: > On Sun, 2020-03-01 at 20:55 +0100, Willy Tarreau wrote: > > This is an update to the first minimal cleanup of the floppy driver in > > order to make use of the FDC number explicit so as to avoid bugs like > > the one fixed by 2e90ca68 ("floppy: check FDC index for errors before > > assigning it"). > > Thanks Willy. > > trivia: you could style check the patches using checkpatch. Oh yes, sorry about this, I did it in the first series but forgot to do it again. What checkpatch complains about is essentially lines which slightly exceed 80 characters due to the macro expansions, while I tried to limit the changes to the strict minimum. I guess that's OK to keep future fixes easier to backport. Thanks, Willy