Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp2023405ybf; Mon, 2 Mar 2020 00:07:51 -0800 (PST) X-Google-Smtp-Source: APXvYqxxEvcq4F1WibYAYihIeMsJdbhL27Oe2Mly+iiE1LA6+eJ46vsc6lkJeFjYNnQNMDUvmcq4 X-Received: by 2002:a9d:23b6:: with SMTP id t51mr11897826otb.15.1583136471257; Mon, 02 Mar 2020 00:07:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583136471; cv=none; d=google.com; s=arc-20160816; b=FCwtuNaeM1BbI1ShIbNEv0C0aPpm2Gjn84DdPU7RtAbUSxGDCWrqLjMNaBPNpVaZq/ 3h/xYhGs1izMhuM1IxmgQDhYWpYNag1HDFmJRFnsXlCZm5/vfACXcEYxGz87QNPMiHH/ Hw2jQs0ePewVg7QeOWBUDZtl2XPetVHUaIDwEEY2NtlYVzvpBdL2PP8TXUGTJHXDQ+a2 FYWr1DQwFkHexdB5axOIZezjKJmh70jzpYNZxmCi6xfaXgkdFjDv3ouI8MJc32ZkwnPI zf9ublHMHHV+pS/IDjVp4Kyz4EH6ZR4BPJ3e58Cr2m4EYbZl1JmMUT4kMX0lDz415ZaR KQMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=MdzIyegemrSrh9c6ddX5ZowYAqAFX3B1apd2cBMGl/0=; b=BDVQFzEjYJGVksfz0BslgK7uDwu9/oeFd2dee89tzta05ppw9UvY9KejOfPPEQ7uSl rio34acx11Nw7hfqSeLi19PFPbpojHMvhAyPKIX5HtG9SMaf+17TM3DEetLT+IvI/Syl 6CtKigqzNX8gQFqFec6fEOQ7Lzl90H0dEzistNDj7KSa/eLIRhsAHLg9dS8hbUdnxva3 Hn4vJ7qjQ+uT6TM33kVnGfsj0/+PYchYedIDN9+AMKtRCdHrpVyXGLRfRqiT3WDUBxt5 3OJIvYYQGxI5Rawjd3FoqTfSOtvChL+zw8eYnjYkDLkDKlI5z8cqRwNAAEf9wKTVsSQL svjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w16si6147708oih.154.2020.03.02.00.07.38; Mon, 02 Mar 2020 00:07:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727192AbgCBIHJ (ORCPT + 99 others); Mon, 2 Mar 2020 03:07:09 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:35605 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726960AbgCBIHJ (ORCPT ); Mon, 2 Mar 2020 03:07:09 -0500 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j8g6R-0004gc-4W; Mon, 02 Mar 2020 09:07:03 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1j8g6O-0001Lz-9A; Mon, 02 Mar 2020 09:07:00 +0100 Date: Mon, 2 Mar 2020 09:07:00 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Anson Huang Cc: rui.zhang@intel.com, daniel.lezcano@linaro.org, amit.kucheria@verdurent.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH V2] thermal: imx_thermal: Use __maybe_unused instead of CONFIG_PM_SLEEP Message-ID: <20200302080700.ubnboqklhbva7bas@pengutronix.de> References: <1583135410-7496-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1583135410-7496-1-git-send-email-Anson.Huang@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 02, 2020 at 03:50:10PM +0800, Anson Huang wrote: > Use __maybe_unused for power management related functions instead > of #if CONFIG_PM_SLEEP to simplify the code. > > Signed-off-by: Anson Huang > Reviewed-by: Uwe Kleine-K?nig IMHO translating my "otherwise looks fine" in a "Reviewed-by" is a bit bold. Please don't assume this. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | https://www.pengutronix.de/ |