Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Benson Leung <bleung@chromium.org>,
        Prashant Malani <pmalani@chromium.org>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        Felipe Balbi <balbi@kernel.org>,
        Chunfeng Yun <chunfeng.yun@mediatek.com>,
        Bin Liu <b-liu@ti.com>
Subject: RE: [PATCH v2 5/9] usb: roles: Provide the switch drivers handle to
 the switch in the API
Thread-Topic: [PATCH v2 5/9] usb: roles: Provide the switch drivers handle to
 the switch in the API
Thread-Index: AQHV6wvzIyZpbIaiske1bsSyj2bnlKgqUqgAgAqNTQCAADDIAIAADpxg
Date:   Mon, 2 Mar 2020 10:14:11 +0000
Message-ID: <VI1PR04MB53278E3B1B3E1FE58C29C6B18BE70@VI1PR04MB5327.eurprd04.prod.outlook.com>
References: <20200224121406.2419-1-heikki.krogerus@linux.intel.com>
 <20200224121406.2419-6-heikki.krogerus@linux.intel.com>
 <20200224131442.GA5365@b29397-desktop> <20200302062302.GE3834@b29397-desktop>
 <20200302091738.GB22243@kuha.fi.intel.com>
In-Reply-To: <20200302091738.GB22243@kuha.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: bafa1861-8a13-491e-c6cc-08d7be9273ec
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2020 10:14:11.4694
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W1qkCXeLhwPKOY3wlqGOw80mebN8Icx+UM5V4/fbx6Di4b8KR0ROnDIr3pprm8n/Uw3AfqC0ygSYGToEuRbgEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5423
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
>=20
> On Mon, Mar 02, 2020 at 06:22:59AM +0000, Peter Chen wrote:
> > > > @@ -613,9 +613,10 @@ static enum usb_role ci_usb_role_switch_get(st=
ruct
> device *dev)
> > > >  	return role;
> > > >  }
> > > >
> > > > -static int ci_usb_role_switch_set(struct device *dev, enum
> > > > usb_role role)
> > > > +static int ci_usb_role_switch_set(struct usb_role_switch *sw,
> > > > +				  enum usb_role role)
> > > >  {
> > > > -	struct ci_hdrc *ci =3D dev_get_drvdata(dev);
> > > > +	struct ci_hdrc *ci =3D usb_role_switch_get_drvdata(sw);
> > > >  	struct ci_hdrc_cable *cable =3D NULL;
> > > >  	enum usb_role current_role =3D ci_role_to_usb_role(ci);
> > > >  	enum ci_role ci_role =3D usb_role_to_ci_role(role); @@ -1118,6
> > > > +1119,7 @@ static int ci_hdrc_probe(struct platform_device *pdev)
> > > >  	}
> > > >
> > > >  	if (ci_role_switch.fwnode) {
> > > > +		ci_role_switch.driver_data =3D ci;
> >
> > And chipidea code, better change it like cdns3's, otherwise, the
> > switch desc for all controllers have the same driver_data.
>=20
> That I'll skip after all...
>=20
> Note that since the context of the switch descriptor is always copied dur=
ing
> registration, the driver_data is not going to be the same for every switc=
h.
>=20

Yes, there is no problem now, just to avoid the issue if usb switch core wi=
ll use
each descriptor in future.

> The structure is actually filled in two separate functions, so the change=
 is not
> straightforward. We can still change that of course, but it's out side th=
e scope of this
> series, so it needs to be done separately.
>=20
=20
Ok, you could leave it like this v2, and I will do it in future.

Peter