Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp2133105ybf; Mon, 2 Mar 2020 02:39:22 -0800 (PST) X-Google-Smtp-Source: ADFU+vsiF8rxMS/pNHDCdGXdJKgHv7aUiO5PjSg3FKvzgEqXPD5sF2+vMPqnb575nPjzT9nyZU8a X-Received: by 2002:a05:6808:a0a:: with SMTP id n10mr2990503oij.10.1583145562739; Mon, 02 Mar 2020 02:39:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583145562; cv=none; d=google.com; s=arc-20160816; b=yYoXcDtxZwDbddyYUObjQTuTFhgGf0PXKIRVkxmCZE7nYKAF6wYCSlhcwDzT2xuR4F 1bueDanQ0dPQ/+XcVmxmYrwDN3710sS1e4PPEjq15ntYX59f6Zf9atkQeCik/CAkkhXB QWBJIMr5grH6f8dHNieroRQO4AMLzlSK1o6CTspcDAfnYag2I+AA6pYKzkYmLA+AHWuW uVPSCsSXzIi9aOohkFY6tsmuX911zozlcZpjgfaswqvsr2+7R6O9OxNaEL8dnklL9EXd jRgKsL22fbqLYGg5P/L9M5rp8lyto6re1s/Rj56SwGXHTkQiGnFp2lLuCwQL9Kt6EeLE l8Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=jRou1cXxB/MPAiePt2r7aScNn6oehYwZxfoaqCXqgbs=; b=DYfFkedZnTPFwzdj7LHPOcTFzYzKgdfrIJvobDo4FkWkzGbbnP/TrhN0pUWybe4E8V 2bNTMk7tQs9S6heDP5nAhuqiOkrVRa/4LwnsY1J/pBAuyN6ncKzMRk8+JM+7e1BS84fe nEa7WfUNiNt9ppV1/yShf49GCj7atHaaCVfSsfaL5xMtUuCYyhgj9vxMN/u8e1+gXxv3 wcvU8nDDZ6exJmGofcl7KaNCO8QowRQ7IM8OTLHlqaOie6zwPdhXEDRTxCpgrYHGC3IM Lh7ADwcepHwB39QuUAVp03QxS4VYQkYqxJOFTMuqCAKHmkKNDHJ42xSwQ+Zxi+SDD6WO mW2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t22si6178432otc.167.2020.03.02.02.39.09; Mon, 02 Mar 2020 02:39:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727656AbgCBKip convert rfc822-to-8bit (ORCPT + 99 others); Mon, 2 Mar 2020 05:38:45 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:45611 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727365AbgCBKio (ORCPT ); Mon, 2 Mar 2020 05:38:44 -0500 Received: by mail-ot1-f67.google.com with SMTP id f21so629100otp.12; Mon, 02 Mar 2020 02:38:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MwWsoH3lbguISoV3Xmb+APpQTE7w8muFrbuI4gr/DUc=; b=MNRvfqPYfSDoi1ID6LgQ+c6vyDPkEN/TJuw6KfXrPs3mhLVoUzMsqMHKRNny9VxCXw eBY+PfOwIpiQ0hy7NvuMlmDtMZv7f+Y51JAJfEPaFfHzGaavhxSA4B4jPfY0Y6ZoWyRC ekKj5ZNiHsaY+0vHyn9ZPOIB/phtHj8Il83/5PQMLfOOa9lTPXVktQeX0Sw9koIvY7FX UO49livVATS0eHT1ysX7YQmRpIf07k4ILGh4TUueWrUcB7TpMCZsVzrfERboSXjf/IYn MDiRrVpvFLHbj8F0OnyyiqswoPZONzmmifXfU9Jqbi1yeVMnePEevGK2ajbkzyOXnXmr F/9Q== X-Gm-Message-State: APjAAAVsz4U3CDzQgz/6ow5x2I4MztOBiIgQRTNhBYEry6oAX00U8oyJ JPCphGTKyv4apdoL0JQs78BJrqVgjHk2zAY5wXhX2j3i X-Received: by 2002:a9d:67d7:: with SMTP id c23mr12866890otn.262.1583145524239; Mon, 02 Mar 2020 02:38:44 -0800 (PST) MIME-Version: 1.0 References: <2094703.CetWLLyMuz@kreacher> In-Reply-To: From: "Rafael J. Wysocki" Date: Mon, 2 Mar 2020 11:38:32 +0100 Message-ID: Subject: Re: [PATCH 0/6] ACPI: EC: Updates related to initialization To: Jian-Hong Pan Cc: "Rafael J. Wysocki" , Daniel Drake , Linux ACPI , LKML , "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 2, 2020 at 6:54 AM Jian-Hong Pan wrote: > > Daniel Drake 於 2020年2月28日 週五 下午5:43寫道: > > > > On Thu, Feb 27, 2020 at 10:25 PM Rafael J. Wysocki wrote: > > > The purpose of this series of update of the ACPI EC driver is to make its > > > initialization more straightforward. > > > > > > They fix a couple of issues, clean up some things, remove redundant code etc. > > > > > > Please refer to the changelogs of individual patches for details. > > > > > > For easier access, the series is available in the git branch at > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ > > > acpi-ec-work > > > > > > on top of 5.6-rc3. > > > > Jian-Hong, can you please test this on Asus UX434DA? > > Check if the screen brightness hotkeys are still working after these changes. > > Hi Rafael, > > Thanks for your patches, but we found an issue: > The laptops like ASUS UX434DA's screen brightness hotkeys work before > this patch series. However, the hotkeys are failed with the patch > "ACPI: EC: Unify handling of event handler installation failures". So I have modified the series to avoid the change that can possibly break this. Can you please pull the new series from git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ acpi-ec-work (same branch) and retest? I'll post the updated patches later this week, but it would be good to try them on now if possible. Thanks!