Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp2157696ybf; Mon, 2 Mar 2020 03:09:56 -0800 (PST) X-Google-Smtp-Source: APXvYqyvgIG8IzsQYwEzScfgQpM+QKSR7tRg20qC5XUk8vVO9oV1Rxqj8iVPYiKe1Z4PQdvTkvLA X-Received: by 2002:a9d:23b6:: with SMTP id t51mr12334454otb.15.1583147396557; Mon, 02 Mar 2020 03:09:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583147396; cv=none; d=google.com; s=arc-20160816; b=X1rFgwXczUw4x+cOo4wTG+kRUo4MJjFm0EN+l+LOaaADN0Rrqxo33XaW8S9usJAF2e uIMbOCjWXNlLN8W8xFujggKLpS6/01gHzjF/7lvh699dG1BSyDEflMtSdUicnJN9JaQa NP8smKgV6KAcrKP5r5YOUmeqYSe+borMEx720N8lqhTutafkOfRDmAk1l/wt/YQGUD9+ rQfur8Q4viM/GYEmNG8FdFbwOXn+QSinclPfz3EsNtrwXASY1CwiRNWVAv0l6JqVe+mL a2z/dOaLEgs1saQTBSo/gvAR8qSMKz6byHQgX85TJgsCqYJ+1m86fym0Nx/MDONknaW1 WpOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=jkJiNniKaFctydfhWfYnGa4X8WaiejBhGb8vhemFpGY=; b=L5Vc71CJZZr7BzxitQlrd/WqWzbXKMGQwt6gd8Vj51Vt9qkPVbUlaKWba95kNtxfAE 0UB1fP4BFZYNyQgLaNEXyJYQOzGuegwahUI5iBIoTjlr9Cppv7jdjGlRvUuJxQGKkVTB XNxwssk4yhhk4XNlQqTM67ZzxcApJ2c9wBCzFdn93jZcSXbMzbAJJmRYIUd3P0DJ6elZ Z0NdZ/cCmBPTL6RG8hdN6zRw2DahNsiH/omu0TgWp6VSJbnQDJAihuhxWfrz8mZHlNaL uUDybQSVPNmL/2b1kuGNOA0xzzeNr1MjZnNepFy3J8g6/kINTAF2qhnQFTwJNQzfJimQ mzcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a25si1540199oid.67.2020.03.02.03.09.43; Mon, 02 Mar 2020 03:09:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727107AbgCBLJf (ORCPT + 99 others); Mon, 2 Mar 2020 06:09:35 -0500 Received: from mga03.intel.com ([134.134.136.65]:30313 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725996AbgCBLJf (ORCPT ); Mon, 2 Mar 2020 06:09:35 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2020 03:09:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,506,1574150400"; d="scan'208";a="440097172" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006.fm.intel.com with ESMTP; 02 Mar 2020 03:09:30 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1j8ix2-00677E-TG; Mon, 02 Mar 2020 13:09:32 +0200 Date: Mon, 2 Mar 2020 13:09:32 +0200 From: Andy Shevchenko To: "Life is hard, and then you die" Cc: Sergiu Cuciurean , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, nikolas@gnu.org, gregkh@linuxfoundation.org, maowenan@huawei.com Subject: Re: [PATCH] input: keyboard: applespi: Use new structure for SPI transfer delays Message-ID: <20200302110932.GS1224808@smile.fi.intel.com> References: <20200227124534.23399-1-sergiu.cuciurean@analog.com> <20200229032616.GA27264@innovation.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200229032616.GA27264@innovation.ch> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 28, 2020 at 07:26:16PM -0800, Life is hard, and then you die wrote: > On Thu, Feb 27, 2020 at 02:45:34PM +0200, Sergiu Cuciurean wrote: ... > > - wr_t->delay_usecs = SPI_RW_CHG_DELAY_US; > > + wr_t->delay.value = SPI_RW_CHG_DELAY_US; > > + wr_t->delay.unit = SPI_DELAY_UNIT_USECS; > > Looks good to me and tested to confirm things still work. Ronald, we have the established tags for such, like Tested-by:, Reviewed-by:. -- With Best Regards, Andy Shevchenko