Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030528AbWBNJcz (ORCPT ); Tue, 14 Feb 2006 04:32:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030529AbWBNJcz (ORCPT ); Tue, 14 Feb 2006 04:32:55 -0500 Received: from cantor2.suse.de ([195.135.220.15]:51135 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1030528AbWBNJcz (ORCPT ); Tue, 14 Feb 2006 04:32:55 -0500 To: Kenji Kaneshige Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, Andrew Morton , Greg KH Subject: Re: [RFC][PATCH 0/4] PCI legacy I/O port free driver References: <43F172BA.1020405@jp.fujitsu.com> From: Andi Kleen Date: 14 Feb 2006 10:32:46 +0100 In-Reply-To: <43F172BA.1020405@jp.fujitsu.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 820 Lines: 18 Kenji Kaneshige writes: > I encountered a problem that some PCI devices don't work on my system > which have huge number of PCI devices. Is that a large IA64 system? [...] The basic concept looks good to me, but I would suggest you use the Linux bitmap functions (DECLARE_BITMAP(), set_bit, test_bit etc.) instead of open coding all that. And for the e1000 change - instead of adding a big switch with magic numbers that will likely bitrot it's better to use the driver_data field in pci_device_id for such device specific flags. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/