Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 2 Mar 2020 13:51:37 +0000
From:   Wei Yang <richard.weiyang@gmail.com>
To:     mateusznosek0@gmail.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org
Subject: Re: [PATCH] mm/mm_init.c: Clean code. Use BUILD_BUG_ON when
 comparing compile time constant
Message-ID: <20200302135137.lm5syk7r2thohs54@master>
Reply-To: Wei Yang <richard.weiyang@gmail.com>
References: <20200228224617.11343-1-mateusznosek0@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200228224617.11343-1-mateusznosek0@gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Feb 28, 2020 at 11:46:17PM +0100, mateusznosek0@gmail.com wrote:
>From: Mateusz Nosek <mateusznosek0@gmail.com>
>
>MAX_ZONELISTS is compile time constant,
>so it should be compared using BUILD_BUG_ON not BUG_ON.
>
>Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>

Sounds you are right.

Reviewed-by: Wei Yang <richard.weiyang@gmail.com>

>---
> mm/mm_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/mm_init.c b/mm/mm_init.c
>index 5c918388de99..7da6991d9435 100644
>--- a/mm/mm_init.c
>+++ b/mm/mm_init.c
>@@ -37,7 +37,7 @@ void __init mminit_verify_zonelist(void)
> 		struct zonelist *zonelist;
> 		int i, listid, zoneid;
> 
>-		BUG_ON(MAX_ZONELISTS > 2);
>+		BUILD_BUG_ON(MAX_ZONELISTS > 2);
> 		for (i = 0; i < MAX_ZONELISTS * MAX_NR_ZONES; i++) {
> 
> 			/* Identify the zone and nodelist */
>-- 
>2.17.1

-- 
Wei Yang
Help you, Help me