Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp2324733ybf; Mon, 2 Mar 2020 06:28:00 -0800 (PST) X-Google-Smtp-Source: APXvYqwdBwa3HqnRsJHolc3I1tu/SUfGWfZ2xio5GMP7z/yEOS5PhHk89Jm5gTL1gqZb4WE/EZkW X-Received: by 2002:a9d:61c5:: with SMTP id h5mr13578243otk.85.1583159279954; Mon, 02 Mar 2020 06:27:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583159279; cv=none; d=google.com; s=arc-20160816; b=PripgzHzp3il69qFE1n560xGP7aqL3cNVJqCNiLU7nkIgKg0OMl9nuwkFrP/XZIqs8 lOL4gE1LibyLUbevemu/S17Br/3EWA/GwAfq/d7fuKg2wuOE4JCEJcVKFaP+a4Go6DV6 0+4tzCtauJXJ+24YdA9VTq1j/0ffDVB0P3KugBLRXlD2A1/xr6WgIHVUuL0jE5/nEBO+ 19YJr8SJS5n/sV+eaM17xdEfVG2JGrgbHrOQxWXFVG3JXauUpX7vvIa+/C0Lb96nD0ed 8HBn7t/asXBemErhiq5mYA3Ji66VUtSc6xCSjXCSWIEDb1q64Xq5frYGMq1X6IwiRH9B eOYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :dkim-signature; bh=3+UBgX7eoIkK/t5w+2bDxE2KMKopb4wrJcspZOaATZ0=; b=IdCWXhe1+RQ0g8HckrZGuf08lAczZTXdPJEKeRYBc33sF38q1favOm9CY7StOUpAgD RftlYmvQnNZcc/Fy0O+iGdfMuADQFjOYM5qMr2FfvMYtpLfIr6De+Jpwp2glEyggr4CV kExIB+LyoI8wPU4C1qoCaqLU3A6aIeA5Ff6ItfHqWN3TyUan0w4Krnb1lyWCu2XJ9S0o emJp9VIfApgQzlPhImkgSzJcipt0WrE3BV+mIEk2qZSA4ix8oZhMisX7liVKK2g9If1H HTuGbO9PzMvhD6SVhbz4M6308PEe3KuQjiPpuSJ1dx7Ihm6PDZBIWy4411OH4bYlgPfb kKbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FYkFLO6y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f204si4834499oib.16.2020.03.02.06.27.46; Mon, 02 Mar 2020 06:27:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FYkFLO6y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727154AbgCBO11 (ORCPT + 99 others); Mon, 2 Mar 2020 09:27:27 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:33524 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727075AbgCBO11 (ORCPT ); Mon, 2 Mar 2020 09:27:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583159246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3+UBgX7eoIkK/t5w+2bDxE2KMKopb4wrJcspZOaATZ0=; b=FYkFLO6yOEtrELHtwzPZxfN051bsIKYVIo8f6FXEQLbSPwt9XE/Of51g0xfuK7YFNX9QMb ucUSwXsh7qNJKb0cnqFNsrOEksUO4p0ujTCZMW9W5kAJ7Wt/MabQCZo3QszaTV7kgdUTsr WsjY+ehtuo/wmO9BRg+tERE5kGOXpP4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-72-_RitG97wNkGAfE8aopeJaA-1; Mon, 02 Mar 2020 09:27:12 -0500 X-MC-Unique: _RitG97wNkGAfE8aopeJaA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DDC02107ACCC; Mon, 2 Mar 2020 14:27:10 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-182.rdu2.redhat.com [10.10.120.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id D890C5D9C9; Mon, 2 Mar 2020 14:27:08 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20200302115239.pcxvej3szmricxzu@wittgenstein> References: <20200302115239.pcxvej3szmricxzu@wittgenstein> <96563.1582901612@warthog.procyon.org.uk> <20200228152427.rv3crd7akwdhta2r@wittgenstein> <87h7z7ngd4.fsf@oldenburg2.str.redhat.com> To: Christian Brauner Cc: dhowells@redhat.com, Florian Weimer , linux-api@vger.kernel.org, viro@zeniv.linux.org.uk, metze@samba.org, torvalds@linux-foundation.org, cyphar@cyphar.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Have RESOLVE_* flags superseded AT_* flags for new syscalls? MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <848281.1583159228.1@warthog.procyon.org.uk> Date: Mon, 02 Mar 2020 14:27:08 +0000 Message-ID: <848282.1583159228@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christian Brauner wrote: > > AT_SYMLINK_NOFOLLOW only applies to the last pathname component anyway, > > so it's relatively little protection. > > So this is partially why I think it's at least worth considerings: the > new RESOLVE_NO_SYMLINKS flag does block all symlink resolution, not just > for the last component in contrast to AT_SYMLINK_NOFOLLOW. This is > 278121417a72d87fb29dd8c48801f80821e8f75a That sounds like a potentially significant UAPI change. What will that break? David