Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 2 Mar 2020 09:36:03 -0600
From:   Corey Minyard <minyard@acm.org>
To:     John Donnelly <john.p.donnelly@oracle.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 ] ipmi_si: Fix false error about IRQ registration
Message-ID: <20200302153603.GD3878@minyard.net>
Reply-To: minyard@acm.org
References: <95A6B0CD-9C09-4165-AF60-A2789C53E926@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <95A6B0CD-9C09-4165-AF60-A2789C53E926@oracle.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Feb 28, 2020 at 03:28:04PM -0600, John Donnelly wrote:
> Since commit 7723f4c5ecdb ("driver core: platform: Add an error message
> to platform_get_irq()"), platform_get_irq() will call dev_err() on an
> error,  even though the IRQ usage in the ipmi_si driver is optional.
> 
> Use the platform_get_irq_optional() call to avoid the message from
> alerting users with false alarms.
> 
> cc: stable@vger.kernel.org # 5.4.x

This looks good to me:

Acked-by: Corey Minyard <cminyard@mvista.com>

I've included in my tree for 5.7

-corey

> 
> Signed-off-by: John Donnelly <john.p.donnelly@oracle.com>
> ---
>  drivers/char/ipmi/ipmi_si_platform.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_si_platform.c
> index c78127ccbc0d..638c693e17ad 100644
> --- a/drivers/char/ipmi/ipmi_si_platform.c
> +++ b/drivers/char/ipmi/ipmi_si_platform.c
> @@ -194,7 +194,7 @@ static int platform_ipmi_probe(struct platform_device *pdev)
>  	else
>  		io.slave_addr = slave_addr;
>  
> -	io.irq = platform_get_irq(pdev, 0);
> +	io.irq = platform_get_irq_optional(pdev, 0);
>  	if (io.irq > 0)
>  		io.irq_setup = ipmi_std_irq_setup;
>  	else
> @@ -378,7 +378,7 @@ static int acpi_ipmi_probe(struct platform_device *pdev)
>  		io.irq = tmp;
>  		io.irq_setup = acpi_gpe_irq_setup;
>  	} else {
> -		int irq = platform_get_irq(pdev, 0);
> +		int irq = platform_get_irq_optional(pdev, 0);
>  
>  		if (irq > 0) {
>  			io.irq = irq;
> -- 
> 2.20.1
>