Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 2 Mar 2020 15:49:49 +0000
From:   Quentin Deslandes <quentin.deslandes@itdev.co.uk>
To:     Oscar Carter <oscar.carter@gmx.com>
Cc:     Forest Bond <forest@alittletooquiet.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Malcolm Priestley <tvboxspy@gmail.com>,
        Gabriela Bittencourt <gabrielabittencourt00@gmail.com>,
        Colin Ian King <colin.king@canonical.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6656: Remove unnecessary local variables
 initialization
Message-ID: <20200302154949.GB11315@qd-ubuntu>
References: <20200301135028.11753-1-oscar.carter@gmx.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200301135028.11753-1-oscar.carter@gmx.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from qd-ubuntu (89.21.227.133) by LO2P265CA0207.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.15 via Frontend Transport; Mon, 2 Mar 2020 15:49:50 +0000
X-Originating-IP: [89.21.227.133]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 1bedc9fc-090c-47bc-2d41-08d7bec157e0
X-MS-TrafficTypeDiagnostic: DBBPR08MB4284:
X-Microsoft-Antispam-PRVS: <DBBPR08MB4284C66C34D741EA5AC7CE27B3E70@DBBPR08MB4284.eurprd08.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1247;
X-Forefront-PRVS: 033054F29A
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(376002)(366004)(396003)(136003)(39830400003)(346002)(199004)(189003)(6496006)(52116002)(54906003)(66556008)(66946007)(186003)(4326008)(9686003)(5660300002)(81166006)(8936002)(81156014)(316002)(956004)(44832011)(16526019)(26005)(8676002)(66476007)(508600001)(1076003)(55016002)(33656002)(33716001)(86362001)(2906002)(6916009)(518174003);DIR:OUT;SFP:1101;SCL:1;SRVR:DBBPR08MB4284;H:DBBPR08MB4491.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
Received-SPF: None (protection.outlook.com: itdev.co.uk does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: n3STBgR1COInKthQ4dJYZLQVqe23tPsrlNjZAjlUMCwwctsPwaQtt7dvgGW60G8zIFZDjt9/fIbGqGnt0Z3bSGDBlqyPucumQLza60lfqMycmo/0RjWZaF1AXJ4iF4QZVLSI5zEGRUWrsu0549IR1dSDwTVGGi61qdGeNPPPZkdQ+1WEUw6SusvVoe/etGOm7A1D1z8exJZv8JYvC0GL38DlUgLZnTz8amQb+7RJopIrT0yVUSnxwgCfOuYUfh0wjkfet4GDyEC3WfvXCVqVKpTNIrEP8F0F+BTk1ZkCwLWNCh2EKDHczRq+fpMci8L8IF0fjRz0Pn+iz+FzN+6LubC/g3xjy2Dbmx+mSxA+hiUMMkaC4qDFaKCKCl9sAwnOm8JImalERNDt1lPlqWFrz9UC1Dgng0qP3T34Y9O4IYyO/McNMAZunvGYJbnmvbm98UD+hyU+j2hKxgIbrqTsw10ufEaRq4i84eB3fiqzb85O/Xl3kfgbsOHSCK5feIBI
X-MS-Exchange-AntiSpam-MessageData: GfsAgzEB1UzuYOS9Ey7YdP+/jRFOmp0zyAy8muOPLbZulgtugsNov4R2wrKC6wLEXrC1Hau7qmyA896ZQgCkOG8nmHphlZ9f5ECQf5jjLGMKZEJ4rvilP8bpxdWkTFZx3OeFi7ZFgx+XoSeZdhW4sg==
X-OriginatorOrg: itdev.co.uk
X-MS-Exchange-CrossTenant-Network-Message-Id: 1bedc9fc-090c-47bc-2d41-08d7bec157e0
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2020 15:49:50.9998
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2d2930c4-2251-45b4-ad79-3582c5f41740
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YkDKz8auORk9PDaBGrrj9GN3KE+oAMYb89EDzDHcJLyLGiGI+2w/OV0ghl58TvFB1KlVLNb+9za/bLXse6aBQ0HtDU+U0hGj6yQ5Gv54o98=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4284
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Mar 01, 2020 at 02:50:28PM +0100, Oscar Carter wrote:
> Don't initialize variables that are then set a few lines later.
> 
> Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
> ---
>  drivers/staging/vt6656/main_usb.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 701300202b21..bfeb5df896fe 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -109,7 +109,7 @@ static void vnt_set_options(struct vnt_private *priv)
>   */
>  static int vnt_init_registers(struct vnt_private *priv)
>  {
> -	int ret = 0;
> +	int ret;
>  	struct vnt_cmd_card_init *init_cmd = &priv->init_command;
>  	struct vnt_rsp_card_init *init_rsp = &priv->init_response;
>  	u8 antenna;
> @@ -435,7 +435,7 @@ static void vnt_free_int_bufs(struct vnt_private *priv)
> 
>  static int vnt_alloc_bufs(struct vnt_private *priv)
>  {
> -	int ret = 0;
> +	int ret;
>  	struct vnt_usb_send_context *tx_context;
>  	struct vnt_rcb *rcb;
>  	int ii;
> @@ -528,7 +528,7 @@ static void vnt_tx_80211(struct ieee80211_hw *hw,
> 
>  static int vnt_start(struct ieee80211_hw *hw)
>  {
> -	int ret = 0;
> +	int ret;
>  	struct vnt_private *priv = hw->priv;
> 
>  	priv->rx_buf_sz = MAX_TOTAL_SIZE_WITH_ALL_HEADERS;
> @@ -798,7 +798,7 @@ static u64 vnt_prepare_multicast(struct ieee80211_hw *hw,
>  	struct vnt_private *priv = hw->priv;
>  	struct netdev_hw_addr *ha;
>  	u64 mc_filter = 0;
> -	u32 bit_nr = 0;
> +	u32 bit_nr;
> 
>  	netdev_hw_addr_list_for_each(ha, mc_list) {
>  		bit_nr = ether_crc(ETH_ALEN, ha->addr) >> 26;
> @@ -973,7 +973,7 @@ vt6656_probe(struct usb_interface *intf, const struct usb_device_id *id)
>  	struct vnt_private *priv;
>  	struct ieee80211_hw *hw;
>  	struct wiphy *wiphy;
> -	int rc = 0;
> +	int rc;
> 
>  	udev = usb_get_dev(interface_to_usbdev(intf));
> 
> --
> 2.20.1
> 

Looks good.

Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>

Thanks,
Quentin