Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] KVM: SVM: Fix svm the vmexit error_code of WRMSR
To:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        Haiwei Li <lihaiwei.kernel@gmail.com>
Cc:     hpa@zytor.com, bp@alien8.de, "mingo@redhat.com" <mingo@redhat.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "joro@8bytes.org" <joro@8bytes.org>, jmattson@google.com,
        wanpengli@tencent.com,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm@vger.kernel.org, x86@kernel.org
References: <CAB5KdOZwZUvgmHX5C53SBU0WttEF4wBFpgqiGahD2OkojQJZ-Q@mail.gmail.com>
 <87o8tehq88.fsf@vitty.brq.redhat.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <30830ba4-d8d3-df58-f039-57e750ae90a7@redhat.com>
Date:   Mon, 2 Mar 2020 17:05:02 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <87o8tehq88.fsf@vitty.brq.redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 02/03/20 13:54, Vitaly Kuznetsov wrote:
>>          enum exit_fastpath_completion *exit_fastpath)
>>   {
>>          if (!is_guest_mode(vcpu) &&
>> -               to_svm(vcpu)->vmcb->control.exit_code ==
>> EXIT_REASON_MSR_WRITE)
> There is an extra newline here (in case it's not just me).

Yes, the whole patch has broken newlines.  I fixed it up and applied.

>> +               (to_svm(vcpu)->vmcb->control.exit_code == SVM_EXIT_MSR) &&
>> +               (to_svm(vcpu)->vmcb->control.exit_info_1 & 1))
>
> Could we add defines for '1' and '0', like
> SVM_EXITINFO_MSR_WRITE/SVM_EXITINFO_MSR_READ maybe?

We can eliminate "& 1" completely since that's what msr_interception does.

Paolo