Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v5 3/3] tpm: ibmvtpm: Add support for TPM 2
To:     Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc:     linux-integrity@vger.kernel.org, aik@ozlabs.ru,
        david@gibson.dropbear.id.au, linux-kernel@vger.kernel.org,
        nayna@linux.vnet.ibm.com, gcwilson@linux.ibm.com, jgg@ziepe.ca
References: <20200228030330.18081-1-stefanb@linux.vnet.ibm.com>
 <20200228030330.18081-4-stefanb@linux.vnet.ibm.com>
 <20200302111514.GC3979@linux.intel.com>
From:   Stefan Berger <stefanb@linux.ibm.com>
Message-ID: <2f8a9519-c1ab-8d46-18c4-4e0f9d53e3ff@linux.ibm.com>
Date:   Mon, 2 Mar 2020 11:21:27 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <20200302111514.GC3979@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/2/20 6:15 AM, Jarkko Sakkinen wrote:
> On Thu, Feb 27, 2020 at 10:03:30PM -0500, Stefan Berger wrote:
>> From: Stefan Berger <stefanb@linux.ibm.com>
>>
>> Support TPM 2 in the IBM vTPM driver. The hypervisor tells us what
>> version of TPM is connected through the vio_device_id.
> I'd prefer "TPM2" over "TPM 2".
Fixed.
>
>> In case a TPM 2 is found, we set the TPM_CHIP_FLAG_TPM2 flag
>> and get the command codes attributes table. The driver does
>> not need the timeouts and durations, though.
> A TPM2 what? TPM2 is not a thing.


I don't know what you mean? Is it the word 'found' and it should be 
'present' ? Otherwise a TPM2 is a 'thing' / object / device, at least to me.


    Stefan