Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1582863389-3118-1-git-send-email-frowand.list@gmail.com> <db823e84-5d59-374f-c616-e67819d62406@gmail.com>
In-Reply-To: <db823e84-5d59-374f-c616-e67819d62406@gmail.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Mon, 2 Mar 2020 11:33:59 -0600
Message-ID: <CAL_JsqKxGdyU0G2soehcGLeGxJFw1Zrm8b8Zem3Jb6aLgJUhyA@mail.gmail.com>
Subject: Re: [PATCH] of: unittest: make gpio overlay test dependent on CONFIG_OF_GPIO
To:     Frank Rowand <frowand.list@gmail.com>
Cc:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alan Tull <atull@kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Feb 28, 2020 at 8:10 AM Frank Rowand <frowand.list@gmail.com> wrote:
>
> Hi Rob,
>
> On 2/27/20 10:16 PM, frowand.list@gmail.com wrote:
> > From: Frank Rowand <frank.rowand@sony.com>
> >
> > Randconfig testing found compile errors in drivers/of/unittest.c if
> > CONFIG_GPIOLIB is not set because CONFIG_OF_GPIO depends on
> > CONFIG_GPIOLIB.  Make the gpio overlay test depend on CONFIG_OF_GPIO.
> >
> > No code is modified, it is only moved to a different location and
> > protected with #ifdef CONFIG_OF_GPIO.  An empty
> > of_unittest_overlay_gpio() is added in the #else.
>
> Should I have used your 'next' or 'for-next' branch for the commit id:
>
> Fixes: f4056e705b2e ("of: unittest: add overlay gpio test to catch gpio hog problem")

Yes, I added it.

Rob