Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp2522879ybf; Mon, 2 Mar 2020 10:18:05 -0800 (PST) X-Google-Smtp-Source: ADFU+vs+Tw8RebKbAIuKqUKgUXec/DXlTG34TFqorYKhHRo6q+2/ORsH5qmo8Bars57Gx551tL4+ X-Received: by 2002:a9d:66c1:: with SMTP id t1mr315779otm.73.1583173085227; Mon, 02 Mar 2020 10:18:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583173085; cv=none; d=google.com; s=arc-20160816; b=shVaeE/V6gcXdHzzmIIoFakE3EPYclnXvTelQJtCRkHemg8A665ZLtYKob2Whp68ix wbJzMBbVm9o/4E21Cx0jvZxo6mzt3x4mRP0MEpHhi+MIcG9evavpeS/cUqlXCv2XytLq cKlG4r95SnG77odnvhhzSSyVDNm2JcAIhg6DOawWV1lVs7cL/Np/D4+V3WIYQEu27pyK oWO+5Xj0PDOazMj73jCnZ4OVRIZrUoZOK4ErPyfiyU0Oa9dWJ860XFwAD5oUru8CqDTV WzwhMQpu/lByHLlz/Wm6pjhkx9cpHTZwf86WskSYcxCvhHI9tvhT0k9fjkkSWKkbaLHx DDkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=G6LVee3Eu8V1mpCnCkuI74/fNcvbSUlWEz5N4JsRVyk=; b=QsTj6EBnwqL1CrudxA9BbDdpffhXRwAns/qizQ4KLmz/9LNF/bD7n8gaoyc4Sd43w6 b7f/FbE/iVG2Uf3KI+tqtVTxcb6geFr+DUEMQj8HnBhmHQIhK+ChPEoF6GKyHRQMXtt/ NUaWfc6SDFXlpVzBeizC8B7pDkmAVHEpO0Q7nRFIhfgI+WTxUyT9Krt5XM21y+Lbqtv4 Er9J3+3nEhrrDqzyN26F4RBjzQA341VizXM5enN9dj0wM0ijtSRsrNf52hIPaIN1r53l Suwkjzm2SoJuheMTw3bA4FB4x4yRh78yXNE5YtpYK4wn6XMbAnZODH3eGWBrGA2GOaN+ foeg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z23si6694191oti.34.2020.03.02.10.17.52; Mon, 02 Mar 2020 10:18:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727261AbgCBSQZ (ORCPT + 99 others); Mon, 2 Mar 2020 13:16:25 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:21250 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726451AbgCBSQY (ORCPT ); Mon, 2 Mar 2020 13:16:24 -0500 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 022I8vds018378 for ; Mon, 2 Mar 2020 13:16:23 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2yfm51nps9-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 02 Mar 2020 13:16:23 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 2 Mar 2020 18:16:20 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 2 Mar 2020 18:16:17 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 022IGG8N58392724 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 2 Mar 2020 18:16:16 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B1BD2A4053; Mon, 2 Mar 2020 18:16:16 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5A67BA4051; Mon, 2 Mar 2020 18:16:16 +0000 (GMT) Received: from spoke.zurich.ibm.com (unknown [9.4.69.152]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 2 Mar 2020 18:16:16 +0000 (GMT) From: Bernard Metzler To: jgg@ziepe.ca, dledford@redhat.com, kamalheib1@gmail.com, krishna2@chelsio.com, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, syzkaller-bugs@googlegroups.com Cc: Bernard Metzler Subject: [PATCH for-rc] RDMA/iwcm: Fix iwcm work deallocation Date: Mon, 2 Mar 2020 19:16:14 +0100 X-Mailer: git-send-email 2.17.2 X-TM-AS-GCONF: 00 x-cbid: 20030218-0012-0000-0000-0000038C5F85 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20030218-0013-0000-0000-000021C91379 Message-Id: <20200302181614.17042-1-bmt@zurich.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-03-02_07:2020-03-02,2020-03-02 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 mlxscore=0 clxscore=1015 bulkscore=0 spamscore=0 mlxlogscore=917 suspectscore=2 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003020119 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The dealloc_work_entries() function must update the work_free_list pointer while freeing its entries, since potentially called again on same list. A second iteration of the work list caused system crash. This happens, if work allocation fails during cma_iw_listen() and free_cm_id() tries to free the list again during cleanup. Reported-by: syzbot+cb0c054eabfba4342146@syzkaller.appspotmail.com Signed-off-by: Bernard Metzler --- drivers/infiniband/core/iwcm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/core/iwcm.c b/drivers/infiniband/core/iwcm.c index ade71823370f..da8adadf4755 100644 --- a/drivers/infiniband/core/iwcm.c +++ b/drivers/infiniband/core/iwcm.c @@ -159,8 +159,10 @@ static void dealloc_work_entries(struct iwcm_id_private *cm_id_priv) { struct list_head *e, *tmp; - list_for_each_safe(e, tmp, &cm_id_priv->work_free_list) + list_for_each_safe(e, tmp, &cm_id_priv->work_free_list) { + list_del(e); kfree(list_entry(e, struct iwcm_work, free_list)); + } } static int alloc_work_entries(struct iwcm_id_private *cm_id_priv, int count) -- 2.17.2