Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3] KVM: X86: Just one leader to trigger kvmclock sync
 request
To:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <kernellwp@gmail.com>
Cc:     Sean Christopherson <sean.j.christopherson@intel.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
References: <1582859921-11932-1-git-send-email-wanpengli@tencent.com>
 <87lfoihpwt.fsf@vitty.brq.redhat.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <f0fe943d-bdd0-1150-6d22-e7e48416da6d@redhat.com>
Date:   Mon, 2 Mar 2020 19:22:08 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <87lfoihpwt.fsf@vitty.brq.redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 02/03/20 14:01, Vitaly Kuznetsov wrote:
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -9389,11 +9389,9 @@ void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu)
>  
>         mutex_unlock(&vcpu->mutex);
>  
> -       if (!kvmclock_periodic_sync)
> -               return;
> -
> -       schedule_delayed_work(&kvm->arch.kvmclock_sync_work,
> -                                       KVMCLOCK_SYNC_PERIOD);
> +       if (vcpu->vcpu_idx == 0 && kvmclock_periodic_sync)
> +               schedule_delayed_work(&kvm->arch.kvmclock_sync_work,
> +                                     KVMCLOCK_SYNC_PERIOD);
>  }

> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Good idea, I squashed the change.

Paolo