Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp2727877ybf; Mon, 2 Mar 2020 14:24:35 -0800 (PST) X-Google-Smtp-Source: ADFU+vs3Q+6fT3XyA9XrK6D0ZKy52NrD8L46eQiCbFCdZ09zFPuJ0IgOv0Cj074APFXMX5Iy2DQT X-Received: by 2002:a9d:6255:: with SMTP id i21mr1102105otk.183.1583187875512; Mon, 02 Mar 2020 14:24:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583187875; cv=none; d=google.com; s=arc-20160816; b=dL207BOWy+R6TiACVj1j7j8Plwgemk0D2I4LQdQZGC3jLGdjMHHL/SVSLDRVawaUp4 WaczlnVsUQtIwl8UCTJtqOOr7Kc2KxGK9vEPyDnrBB99b9B/fQkadNeQJv6YBjL+Lmbn 6+/08YQ+BfvBwKiSYKjA0im1jTqVOFwPSY7B9XPEOiLiHZKOYYS42kH0k5q905/frAvV xD59ZROVgGvc4WA2mG3thmDyU2Cad29DW+0eLgPUFODSy63F33q9NAy203y9B0NjtvoG 69sjDvFPH0otzLYsRhT5tiLw42is6/4di9XrOswBOztQRJ5vC9d+UHzUpyW3ezzmHIzp OP2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=n/m0nhugVbb4gyGZstMRphKfKkDw6ZcO9UWNabnIdzE=; b=SJIpF3RsHNStuSl6b1W6yD2kUYFdkQFGlxuuLF0K0V7olTmwJdwfOQ2YmMFnEpvq1a 7JjDtrABGr+SxKwrB90VpaBaJq8SNGauHF25UZuqiHK21u1AgrDtZl7rbV9vGPCrtuYM NMiPKdDzz4rbij3Il/eLIJIQrqR0LaSNKTC9IWPnlD/178PXctiS83nu3h4xs7wy2XiJ mOzJ2gy0TIFMGXemYSsOwsr+5OtpcBpi8M+IV0dJY6JLvcJ9SodguKqfJtNmgZyT9EkE PFfFehlGjStj+BGvZPUZYAklFwmo7nr7cNOZShMOMannlqZEqlq5FjXqsKgZTmbcB6vx yBaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="V/qsC4MI"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m67si6785653oib.117.2020.03.02.14.24.22; Mon, 02 Mar 2020 14:24:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="V/qsC4MI"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726816AbgCBWYO (ORCPT + 99 others); Mon, 2 Mar 2020 17:24:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:38296 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725781AbgCBWYN (ORCPT ); Mon, 2 Mar 2020 17:24:13 -0500 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B597421775; Mon, 2 Mar 2020 22:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583187853; bh=JUU4hEGar97jd+V9k2N9lDEIJZMNf+Nfj+ecj2VanY4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=V/qsC4MIBAWcfedFF9SutIYTIaKV0oVS8iCnFgaa6E1jLw3KpHxkKliWr7CsDcakJ msAYZl44Nk/pYtoLL6DV6GCON0+oUguHaQ+pT0TezlWz9BE4LhccfO6Td8JX+FtF6f Ui3csBq7LDMKCXTzP+CUnkwubKa926b83ECFvsOs= Date: Mon, 2 Mar 2020 14:24:12 -0800 From: Andrew Morton To: Catalin Marinas Cc: Mike Rapoport , Will Deacon , Naresh Kamboju , anshuman.khandual@arm.com, Linux-Next Mailing List , Linux Kernel Mailing List , Stephen Rothwell , Arnd Bergmann , lkft-triage@lists.linaro.org, suzuki.poulose@arm.com, Anders Roxell Subject: Re: Linux-next-20200302: arm64 build failed Message-Id: <20200302142412.f8f2b17a3387b46ce94c7cb6@linux-foundation.org> In-Reply-To: <20200302174553.GC4166275@arrakis.emea.arm.com> References: <20200302104726.GA7995@willie-the-truck> <20200302135443.GA24831@linux.ibm.com> <20200302174553.GC4166275@arrakis.emea.arm.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Mar 2020 17:45:53 +0000 Catalin Marinas wrote: > > static void unmap_hotplug_range(unsigned long addr, unsigned long end, > > bool free_mapped) > > { > > @@ -854,7 +872,7 @@ static void unmap_hotplug_range(unsigned long addr, unsigned long end, > > continue; > > > > WARN_ON(!pgd_present(pgd)); > > - unmap_hotplug_pud_range(pgdp, addr, next, free_mapped); > > + unmap_hotplug_p4d_range(pgdp, addr, next, free_mapped); > > } while (addr = next, addr < end); > > } > > Thanks Mike. With the additional diff below, I can get it to build with > and without the p4d clean-up patches in -next. If Anshuman confirms that > they work, I can add them on top of the arm64 for-next/memory-hotremove > branch Can't I simply fold these into the offending -mm arm-arm64-add-support-for-folded-p4d-page-tables.patch?