Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 70B65C43383
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Leho Kraav <leho@kraav.com>
Cc:     "Jan Alexander Steffens \(heftig\)" <jan.steffens@gmail.com>,
        Johannes Berg <johannes.berg@intel.com>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        Luca Coelho <luciano.coelho@intel.com>,
        Intel Linux Wireless <linuxwifi@intel.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: pcie: restore support for Killer Qu C0 NICs
References: <20191224051639.6904-1-jan.steffens@gmail.com>
        <20200221121135.GA9056@papaya>
Date:   Tue, 03 Mar 2020 07:40:26 +0200
In-Reply-To: <20200221121135.GA9056@papaya> (Leho Kraav's message of "Fri, 21
        Feb 2020 14:11:35 +0200")
Message-ID: <871rqauhbp.fsf@tynnyri.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Leho Kraav <leho@kraav.com> writes:

> On Tue, Dec 24, 2019 at 06:16:39AM +0100, Jan Alexander Steffens (heftig) wrote:
>> Commit 809805a820c6 ("iwlwifi: pcie: move some cfg mangling from
>> trans_pcie_alloc to probe") refactored the cfg mangling. Unfortunately,
>> in this process the lines which picked the right cfg for Killer Qu C0
>> NICs after C0 detection were lost. These lines were added by commit
>> b9500577d361 ("iwlwifi: pcie: handle switching killer Qu B0 NICs to
>> C0").
>> 
>> I suspect this is more of the "merge damage" which commit 7cded5658329
>> ("iwlwifi: pcie: fix merge damage on making QnJ exclusive") talks about.
>> 
>> Restore the missing lines so the driver loads the right firmware for
>> these NICs.
>
> This seems real, as upgrading 5.5.0 -> 5.5.5 just broke my iwlwifi on XPS 7390.
> How come?

Luca, should I apply this to wireless-drivers?

https://patchwork.kernel.org/patch/11309095/

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches