Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 2 Mar 2020 22:03:51 -0800
From:   "Life is hard, and then you die" <ronald@innovation.ch>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Sergiu Cuciurean <sergiu.cuciurean@analog.com>,
        linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
        dmitry.torokhov@gmail.com, nikolas@gnu.org,
        gregkh@linuxfoundation.org, maowenan@huawei.com
Subject: Re: [PATCH] input: keyboard: applespi: Use new structure for SPI
 transfer delays
Message-ID: <20200303060351.GA12060@innovation.ch>
References: <20200227124534.23399-1-sergiu.cuciurean@analog.com>
 <20200229032616.GA27264@innovation.ch>
 <20200302110932.GS1224808@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200302110932.GS1224808@smile.fi.intel.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Mon, Mar 02, 2020 at 01:09:32PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 28, 2020 at 07:26:16PM -0800, Life is hard, and then you die wrote:
> > On Thu, Feb 27, 2020 at 02:45:34PM +0200, Sergiu Cuciurean wrote:
> 
> ...
> 
> > > -	wr_t->delay_usecs = SPI_RW_CHG_DELAY_US;
> > > +	wr_t->delay.value = SPI_RW_CHG_DELAY_US;
> > > +	wr_t->delay.unit = SPI_DELAY_UNIT_USECS;
> > 
> > Looks good to me and tested to confirm things still work.
> 
> Ronald, we have the established tags for such, like Tested-by:, Reviewed-by:.

Apologies, that was sloppy of me. So:

Tested-by: Ronald Tschal?r <ronald@innovation.ch>
Reviewed-by: Ronald Tschal?r <ronald@innovation.ch>


  Cheers,

  Ronald