Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp3115089ybf; Mon, 2 Mar 2020 23:23:05 -0800 (PST) X-Google-Smtp-Source: ADFU+vvEu4rgNN9b3GeXkLNPxiOOrNIZHz+YHlYKCjp47+0gjJCsMVXhZjn0F8ASAE83QEwNZkzP X-Received: by 2002:a05:6830:143:: with SMTP id j3mr2370678otp.355.1583220185107; Mon, 02 Mar 2020 23:23:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583220185; cv=none; d=google.com; s=arc-20160816; b=N0nC8tv2Gp5GHDIOh8n0Dlz7yPkIGHam9FuyF1yc9URlU/x0BZJo9lsZxD02826GW0 Uhhna2cRJL2Yorws9jOlT/7bEiH3UQ1GbcPl1VBkXMLlcFYYrioxGLCPLmmFux/1APRL P4Jvmyh1gpnd8gtsgeZrf7I6cP3BtVjpzxlDZmc/uyefNk5t+WfNoO8qw45S1oISpDfW 7KZkBTserLLW/ORZVuyfrbBsJsdct+9D2Ehs5fUv0W5U/mmFdqgrllUNiYhfKw8LAVo3 oJwTivcIZO9lw3wN6OX5+djgrW9Qp3h+7Y3GmuasJxrbGEDiTw8WjFQ73K5ntNN+TiaR wnaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=6YIBYv/DHqUoDX1YmoRy4BWctM8bFk193ETadZIOvq4=; b=JQQhAW7e5dQq3RHNW906+Y6F8gyAo9nHfRLYm4jfrMgLZesfEYFLaNoQmLI3V+FRov 2VE0pJvxaUk9Fesa3gZrJMOmRLNcm3vH95umhWlOTDLnp6Anma9t0sD89s8wFN5uWWYt IfWgoIWwBFpXO3bSXKpV3SKQulDcEISVfXzqM8Pb1OW7hGZqoqOiSInVsvpTu4d7yham Qa/oBg1z/5sEmdf+5JyfpJ9Jpa+ekvF4vTxx9z9NCG+VZQzezYMdpf6kp0QopLD9O/1Y PhOdotNHaq/UoIkFqytkc5Q6H/0Yzh7zcRo+u7Syf3lvLNHhkD5urxladPq6Tc/0lOsy ZISA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KhVCJjKr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u4si1888122oic.115.2020.03.02.23.22.53; Mon, 02 Mar 2020 23:23:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KhVCJjKr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727716AbgCCHWY (ORCPT + 99 others); Tue, 3 Mar 2020 02:22:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:58354 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727340AbgCCHWY (ORCPT ); Tue, 3 Mar 2020 02:22:24 -0500 Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C47120726; Tue, 3 Mar 2020 07:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583220143; bh=6YIBYv/DHqUoDX1YmoRy4BWctM8bFk193ETadZIOvq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KhVCJjKrLsUAcy30HilGoH/rhXQQJrxcWODNWV0v/cj1LlKO1lFikpimXXyD3DgAI tr3zrml69xNDViend8iUBQUuDFgjRv5dN3YT2qkSpQUgiJmrBPnRu6kVBCaJJYiHHN dGfzMWTmTqgeR0k0sQH2A1ljH4BBKL2RFIwWXj+c= Date: Tue, 3 Mar 2020 09:22:20 +0200 From: Leon Romanovsky To: Bernard Metzler Cc: dledford@redhat.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [Patch for-rc v2] RDMA/siw: Fix failure handling during device creation Message-ID: <20200303072220.GE121803@unreal> References: <20200302155814.9896-1-bmt@zurich.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200302155814.9896-1-bmt@zurich.ibm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 02, 2020 at 04:58:14PM +0100, Bernard Metzler wrote: > A failing call to ib_device_set_netdev() during device creation > caused system crash due to xa_destroy of uninitialized xarray > hit by device deallocation. Fixed by moving xarray initialization > before potential device deallocation. > > Fixes: bdcf26bf9b3a (rdma/siw: network and RDMA core interface) Fixes line should be slightly different. Fixes: bdcf26bf9b3a ("rdma/siw: network and RDMA core interface") Thanks