Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200228170210.18252-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <CAMuHMdUn9njDRWZPcSD87YuejmhNvDK3pUqL5kXNX6KA-8Y72g@mail.gmail.com> <CA+V-a8tZaAp3q0JtavGK0MV4MxcZqNMkuvY=dMj8CFu7k3w0NA@mail.gmail.com>
In-Reply-To: <CA+V-a8tZaAp3q0JtavGK0MV4MxcZqNMkuvY=dMj8CFu7k3w0NA@mail.gmail.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 3 Mar 2020 09:10:33 +0100
Message-ID: <CAMuHMdWtom=LB93K_KLBZaRUgTDue8HYArhs5jf0gBG1eMCMVw@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: renesas: r8a774c0-cat874: Add support for
 AISTARVISION MIPI Adapter V2.1
To:     "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc:     Magnus Damm <magnus.damm@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Linux Media Mailing List <linux-media@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Lad,

On Tue, Mar 3, 2020 at 8:51 AM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> On Mon, Mar 2, 2020 at 3:57 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Fri, Feb 28, 2020 at 6:02 PM Lad Prabhakar
> > <prabhakar.csengg@gmail.com> wrote:
> > > This patch adds support AISTARVISION MIPI Adapter V2.1 board connected
> > > to G2E board. Common file aistarvision-mipi-adapter-2.1.dtsi is created
> > > which have the camera endpoint nodes with disabled status and in
> > > r8a774c0-ek874-mipi-2.1.dts file VIN/CSI nodes are enabled. By default
> > > imx219 endpoint is tied with CSI2.
> > >
> > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts

> > > +
> > > +&ov5645 {
> > > +       /* uncomment status and remote-endpoint properties to tie ov5645
> > > +        * to CSI2 also make sure remote-endpoint for imx219 camera is
> > > +        * commented and remote endpoint in csi40_in is ov5645_ep
> > > +        */
> > > +       /* status = "okay"; */
> > > +
> > > +       #address-cells = <1>;
> > > +       #size-cells = <0>;
> >
> > #{address,size}-cells not needed.
> >
> agreed will drop it.
>
> > > +       enable-gpios = <&gpio5 5 GPIO_ACTIVE_HIGH>;
> > > +       reset-gpios = <&gpio5 3 GPIO_ACTIVE_LOW>;
> > > +
> > > +       clocks = <&cpg CPG_MOD 716>;
> > > +       clock-frequency = <24000000>;
> >
> > I know this is dictated by the DT bindings for the ov5645 camera, but
> > specifying a clock rate is usually done through assigned-clock-rates,
> > cfr.  Documentation/devicetree/bindings/clock/clock-bindings.txt.
> >
> agreed will replace it.

Note that doing so means you have to fix the ov5645 driver, too.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds