Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp3184664ybf; Tue, 3 Mar 2020 01:00:06 -0800 (PST) X-Google-Smtp-Source: ADFU+vsimpdlOAADuNZG6/lKi7A3wmhTIurgsi8B1KpfS0erLosJPt+XNYSSabmCRsVDZN9AWMoU X-Received: by 2002:aca:2307:: with SMTP id e7mr1740568oie.163.1583226006295; Tue, 03 Mar 2020 01:00:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583226006; cv=none; d=google.com; s=arc-20160816; b=L/VQSK9i2DwQh7HT9Y2hFftOlw/BROkg9fPPpiz8vzZXkAzHdBIhz4txPzvix5SUbI WdPGbQKyxYJ3vnTCy4CGJcYxSDiK27g+t3TU2n3ejjSa56d2vG58QIR3wBfR7mA3K1Bz WsNeuykHWxyDxrBbqYaIeEjp4zXHaGBDm6s3SE9HYrX9pponYYGyZVD/End1iQweDPoV eKmSc5CXUISe7AWlqcUHwba4M1Bao17VB5VwYjewuzJeHLJqLcEE6lxoOyagNdVYHW0a /Gy7rovE9Tt2bFWRwFrc1Xn5GI86aJ5jxTznrkyw78VExXwC05kqZ9pP286r41hJSD1I D3kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:from:references:cc:to:subject :dkim-signature; bh=Kp0XyTWrMUPNYfT6+rfxcT5Op3P4n5f1CbxbxYRrw7s=; b=mImXeTcOf72y6axEhHRotbR70/IyCsbDy5oEp6BF3SaFZ98A+3Jf1rWzQ3SV9ag43n e/WGZT+tLHUpPSGaQ7uKmP17wv6wooZ/6vQr3nh4A/xZFGO8LaK1bqT/P0taKmXEzOw9 N0dlTE2g12INYdai1agRzb/YThcpo1iONGKB4zAnBudBcGRZDvBqG8lgIwKWXkbguU8I yvmN/Y8IFrWJi/ot+M7sLiFcrva15gZ8zv3imNJx5OtKsKFObZh7bjf5IYKTH5cP0IBW EEqNp7qVNpKeqneL0i48C1WjvXwDMgQa+ri+OrFKqXm/pJNhHy7sjAbeLMbD79nDiMI/ wdZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=I38yU7mh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3si7814808oig.25.2020.03.03.00.59.42; Tue, 03 Mar 2020 01:00:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=I38yU7mh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727929AbgCCI7P (ORCPT + 99 others); Tue, 3 Mar 2020 03:59:15 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:33986 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727707AbgCCI7P (ORCPT ); Tue, 3 Mar 2020 03:59:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583225953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Kp0XyTWrMUPNYfT6+rfxcT5Op3P4n5f1CbxbxYRrw7s=; b=I38yU7mhdBkcBzCooimuk0/ZYgOjnFpNMy1+7LXSWKbE4KYeao4eIoGAJtAT7j4AWDbyQ7 DPESJLlXPBWKcnDyL4d8YeEhBZ4GkiIZydgCCdrY6aOgSICUIXFoM4izvTYNia5afLYIy9 eCAViv73jrZh+946+WOOrDbYUaAexmk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-150-a7oGbn7_Mye38Dy9TKuLMQ-1; Tue, 03 Mar 2020 03:59:12 -0500 X-MC-Unique: a7oGbn7_Mye38Dy9TKuLMQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 688FC800D48; Tue, 3 Mar 2020 08:59:10 +0000 (UTC) Received: from [10.36.117.113] (ovpn-117-113.ams2.redhat.com [10.36.117.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C81A1001B0B; Tue, 3 Mar 2020 08:59:09 +0000 (UTC) Subject: Re: [PATCH] mm/vmscan.c: Clean code by removing unnecessary assignment To: mateusznosek0@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org References: <20200229214022.11853-1-mateusznosek0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMFCQlmAYAGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl3pImkCGQEACgkQTd4Q 9wD/g1o+VA//SFvIHUAvul05u6wKv/pIR6aICPdpF9EIgEU448g+7FfDgQwcEny1pbEzAmiw zAXIQ9H0NZh96lcq+yDLtONnXk/bEYWHHUA014A1wqcYNRY8RvY1+eVHb0uu0KYQoXkzvu+s Dncuguk470XPnscL27hs8PgOP6QjG4jt75K2LfZ0eAqTOUCZTJxA8A7E9+XTYuU0hs7QVrWJ jQdFxQbRMrYz7uP8KmTK9/Cnvqehgl4EzyRaZppshruKMeyheBgvgJd5On1wWq4ZUV5PFM4x II3QbD3EJfWbaJMR55jI9dMFa+vK7MFz3rhWOkEx/QR959lfdRSTXdxs8V3zDvChcmRVGN8U Vo93d1YNtWnA9w6oCW1dnDZ4kgQZZSBIjp6iHcA08apzh7DPi08jL7M9UQByeYGr8KuR4i6e RZI6xhlZerUScVzn35ONwOC91VdYiQgjemiVLq1WDDZ3B7DIzUZ4RQTOaIWdtXBWb8zWakt/ ztGhsx0e39Gvt3391O1PgcA7ilhvqrBPemJrlb9xSPPRbaNAW39P8ws/UJnzSJqnHMVxbRZC Am4add/SM+OCP0w3xYss1jy9T+XdZa0lhUvJfLy7tNcjVG/sxkBXOaSC24MFPuwnoC9WvCVQ ZBxouph3kqc4Dt5X1EeXVLeba+466P1fe1rC8MbcwDkoUo65Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAiUEGAECAA8FAlXLn5ECGwwFCQlmAYAACgkQTd4Q 9wD/g1qA6w/+M+ggFv+JdVsz5+ZIc6MSyGUozASX+bmIuPeIecc9UsFRatc91LuJCKMkD9Uv GOcWSeFpLrSGRQ1Z7EMzFVU//qVs6uzhsNk0RYMyS0B6oloW3FpyQ+zOVylFWQCzoyyf227y GW8HnXunJSC+4PtlL2AY4yZjAVAPLK2l6mhgClVXTQ/S7cBoTQKP+jvVJOoYkpnFxWE9pn4t H5QIFk7Ip8TKr5k3fXVWk4lnUi9MTF/5L/mWqdyIO1s7cjharQCstfWCzWrVeVctpVoDfJWp 4LwTuQ5yEM2KcPeElLg5fR7WB2zH97oI6/Ko2DlovmfQqXh9xWozQt0iGy5tWzh6I0JrlcxJ ileZWLccC4XKD1037Hy2FLAjzfoWgwBLA6ULu0exOOdIa58H4PsXtkFPrUF980EEibUp0zFz GotRVekFAceUaRvAj7dh76cToeZkfsjAvBVb4COXuhgX6N4pofgNkW2AtgYu1nUsPAo+NftU CxrhjHtLn4QEBpkbErnXQyMjHpIatlYGutVMS91XTQXYydCh5crMPs7hYVsvnmGHIaB9ZMfB njnuI31KBiLUks+paRkHQlFcgS2N3gkRBzH7xSZ+t7Re3jvXdXEzKBbQ+dC3lpJB0wPnyMcX FOTT3aZT7IgePkt5iC/BKBk3hqKteTnJFeVIT7EC+a6YUFg= Organization: Red Hat GmbH Message-ID: <4f7ab7ce-de14-caa7-5609-0e4004ab3bfd@redhat.com> Date: Tue, 3 Mar 2020 09:59:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200229214022.11853-1-mateusznosek0@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.02.20 22:40, mateusznosek0@gmail.com wrote: > From: Mateusz Nosek > > Previously 0 was assigned to variable 'lruvec_size', > but the variable was never read later. > So the assignment can be removed. > > Signed-off-by: Mateusz Nosek > --- > mm/vmscan.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index f14c8c6069a6..a605ff36f126 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2427,10 +2427,8 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, > case SCAN_FILE: > case SCAN_ANON: > /* Scan one type exclusively */ > - if ((scan_balance == SCAN_FILE) != file) { > - lruvec_size = 0; > + if ((scan_balance == SCAN_FILE) != file) > scan = 0; > - } > break; > default: > /* Look ma, no brain */ > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb