Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1583222684-10229-1-git-send-email-Anson.Huang@nxp.com> <1583222684-10229-2-git-send-email-Anson.Huang@nxp.com>
In-Reply-To: <1583222684-10229-2-git-send-email-Anson.Huang@nxp.com>
From:   Amit Kucheria <amit.kucheria@verdurent.com>
Date:   Tue, 3 Mar 2020 14:44:38 +0530
Message-ID: <CAHLCerNLQ11UR8AW2DcKC+9rh39KPWJG2uRiWGuwbFbyqPH72Q@mail.gmail.com>
Subject: Re: [PATCH 2/2] thermal: Remove COMPILE_TEST for IMX_SC_THERMAL
To:     Anson Huang <Anson.Huang@nxp.com>
Cc:     Zhang Rui <rui.zhang@intel.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Linux PM list <linux-pm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, Linux-imx@nxp.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 3, 2020 at 1:40 PM Anson Huang <Anson.Huang@nxp.com> wrote:
>
> i.MX SCU thermal driver depends on IMX_SCU which does NOT have
> COMPILE_TEST enabled, so need to remove COMPILE_TEST for i.MX
> SCU thermal as well.

Wouldn't a better solution be to add COMPILE_TEST to IMX_SCU to
improve compile coverage?

> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
>  drivers/thermal/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 165b7d6..4fb87df 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -253,7 +253,7 @@ config IMX_THERMAL
>
>  config IMX_SC_THERMAL
>         tristate "Temperature sensor driver for NXP i.MX SoCs with System Controller"
> -       depends on IMX_SCU || COMPILE_TEST
> +       depends on IMX_SCU
>         depends on OF
>         help
>           Support for Temperature Monitor (TEMPMON) found on NXP i.MX SoCs with
> --
> 2.7.4
>