Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422679AbWBNRG0 (ORCPT ); Tue, 14 Feb 2006 12:06:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422681AbWBNRG0 (ORCPT ); Tue, 14 Feb 2006 12:06:26 -0500 Received: from scrub.xs4all.nl ([194.109.195.176]:41197 "EHLO scrub.xs4all.nl") by vger.kernel.org with ESMTP id S1422679AbWBNRGZ (ORCPT ); Tue, 14 Feb 2006 12:06:25 -0500 Date: Tue, 14 Feb 2006 18:06:14 +0100 (CET) From: Roman Zippel X-X-Sender: roman@scrub.home To: George Anzinger cc: Andrew Morton , linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@elte.hu Subject: Re: [PATCH 08/12] hrtimer: completely remove it_real_value In-Reply-To: <43F20CCA.6010105@wildturkeyranch.net> Message-ID: References: <43F20CCA.6010105@wildturkeyranch.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1274 Lines: 30 Hi, On Tue, 14 Feb 2006, George Anzinger wrote: > > Remove the it_real_value from /proc/*/stat, during 1.2.x was the last > > time it returned useful data (as it was directly maintained by the > > scheduler), now it's only a waste of time to calculate it. > > This may be true but this changes the order of items presented making any > "code" looking for items after it_real_value in the list look at the wrong > thing. If we are going to change this, I think we need some sort of version > in the output. Something that changes when ever the output format or content > is modified in any way. I think you missed this: > > @@ -413,7 +411,7 @@ static int do_task_stat(struct task_stru > > start_time = nsec_to_clock_t(start_time); > > res = sprintf(buffer,"%d (%s) %c %d %d %d %d %d %lu %lu \ > > -%lu %lu %lu %lu %lu %ld %ld %ld %ld %d %ld %llu %lu %ld %lu %lu %lu %lu %lu > > \ > > +%lu %lu %lu %lu %lu %ld %ld %ld %ld %d 0 %llu %lu %ld %lu %lu %lu %lu %lu \ ^ bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/