Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp3446433ybf; Tue, 3 Mar 2020 06:14:05 -0800 (PST) X-Google-Smtp-Source: ADFU+vs6/iGCPQZYecTkpBWOYzQs3SIm2AatjThEp63JIl0xyurscS/Fp2+gzIav7LvCYiBn16M5 X-Received: by 2002:a9d:6c8e:: with SMTP id c14mr3223078otr.331.1583244845082; Tue, 03 Mar 2020 06:14:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583244845; cv=none; d=google.com; s=arc-20160816; b=dAcPrS3B715poKTBSwt7QiMbmp64noQr9LLkU5iWhe+uXv2NPd2yiCvDi6DkfF2TIJ 4Ov0G/jpnNTLOScuPTQrORSYSnzRCPInB0u/2f/Repw4v+brI1/iNTjmErDb0DsYyFdn jY/EDZl+qaiakrRF/ntUUqOWyfWcK1wylmccy/ytSds0BwVyDmACdNkT7KXVAi7ceVkh 3sSyHaHjIKeeK/B4qPf4gnvEtssMN/mBvYncAjjZqema370EYNFrcjFW76DBK6VH2M7i eHxq2NbjU3gw4g0buNTKrczLJctbkeXtXZ3A/SI7s37wMHprhp662YxwBGqD3seU8j2U 8Ueg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=ltGwx3PGiZxdHrapel5fyOnI1XP/NnNulpQeVY7T9r4=; b=fNQt6PCy0IzkcEzbGjnZ8bRmZg9Ys3eRDleOM+xQ/OJe4bZFS4e/QWV0PjtqHXy7RK 6tZ4GAW31XpUNJPsb89AqKDyFNJuFkFdZBPWcLg4zGs/VCep4YCdA6l1bqYWqafchhn3 Sv4hP/CqNzM0s7+W4b/ayAkpJZOQXyxpQXGDHjBE3yN3jbxfQGjj06jSjuGTvJSX+8cj dWfXvHQ8W1CrcBnB5h0yd9CS0vJj00ADqJpwt71M1AWMUXDf6+pdhYKBfskCCq40oe95 P4oyrEvB0F9fg9VDsOWwQ6NV/ItuhhGDEWeMvxIqSP9cNDrgVKjhs26AYqvIIpudzTCV CjbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d196si8196043oig.268.2020.03.03.06.13.47; Tue, 03 Mar 2020 06:14:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728945AbgCCOLO (ORCPT + 99 others); Tue, 3 Mar 2020 09:11:14 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:44817 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbgCCOLO (ORCPT ); Tue, 3 Mar 2020 09:11:14 -0500 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j98GK-0007Kd-2l; Tue, 03 Mar 2020 15:11:08 +0100 Received: from [IPv6:2a03:f580:87bc:d400:124:7ee3:e89c:2c00] (unknown [IPv6:2a03:f580:87bc:d400:124:7ee3:e89c:2c00]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mkl@blackshift.org", Issuer "StartCom Class 1 Client CA" (not verified)) (Authenticated sender: mkl@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id E74E14C57D7; Tue, 3 Mar 2020 14:11:04 +0000 (UTC) Subject: Re: [PATCH v1] net: phy: tja11xx: add TJA1102 support To: Andrew Lunn , Oleksij Rempel Cc: Marek Vasut , Florian Fainelli , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pengutronix Kernel Team , David Jander , Christian Herber , "David S. Miller" , Heiner Kallweit References: <2228b5de-89e3-d61a-4af9-8d1a8a5eb311@pengutronix.de> <20200303140912.GH31977@lunn.ch> From: Marc Kleine-Budde Openpgp: preference=signencrypt Autocrypt: addr=mkl@pengutronix.de; prefer-encrypt=mutual; keydata= mQINBFFVq30BEACtnSvtXHoeHJxG6nRULcvlkW6RuNwHKmrqoksispp43X8+nwqIFYgb8UaX zu8T6kZP2wEIpM9RjEL3jdBjZNCsjSS6x1qzpc2+2ivjdiJsqeaagIgvy2JWy7vUa4/PyGfx QyUeXOxdj59DvLwAx8I6hOgeHx2X/ntKAMUxwawYfPZpP3gwTNKc27dJWSomOLgp+gbmOmgc 6U5KwhAxPTEb3CsT5RicsC+uQQFumdl5I6XS+pbeXZndXwnj5t84M+HEj7RN6bUfV2WZO/AB Xt5+qFkC/AVUcj/dcHvZwQJlGeZxoi4veCoOT2MYqfR0ax1MmN+LVRvKm29oSyD4Ts/97cbs XsZDRxnEG3z/7Winiv0ZanclA7v7CQwrzsbpCv+oj+zokGuKasofzKdpywkjAfSE1zTyF+8K nxBAmzwEqeQ3iKqBc3AcCseqSPX53mPqmwvNVS2GqBpnOfY7Mxr1AEmxdEcRYbhG6Xdn+ACq Dq0Db3A++3PhMSaOu125uIAIwMXRJIzCXYSqXo8NIeo9tobk0C/9w3fUfMTrBDtSviLHqlp8 eQEP8+TDSmRP/CwmFHv36jd+XGmBHzW5I7qw0OORRwNFYBeEuiOIgxAfjjbLGHh9SRwEqXAL kw+WVTwh0MN1k7I9/CDVlGvc3yIKS0sA+wudYiselXzgLuP5cQARAQABtCZNYXJjIEtsZWlu ZS1CdWRkZSA8bWtsQHBlbmd1dHJvbml4LmRlPokCVAQTAQoAPgIbAwIeAQIXgAULCQgHAwUV CgkICwUWAgMBABYhBMFAC6CzmJ5vvH1bXCte4hHFiupUBQJcUsSbBQkM366zAAoJECte4hHF iupUgkAP/2RdxKPZ3GMqag33jKwKAbn/fRqAFWqUH9TCsRH3h6+/uEPnZdzhkL4a9p/6OeJn Z6NXqgsyRAOTZsSFcwlfxLNHVxBWm8pMwrBecdt4lzrjSt/3ws2GqxPsmza1Gs61lEdYvLST Ix2vPbB4FAfE0kizKAjRZzlwOyuHOr2ilujDsKTpFtd8lV1nBNNn6HBIBR5ShvJnwyUdzuby tOsSt7qJEvF1x3y49bHCy3uy+MmYuoEyG6zo9udUzhVsKe3hHYC2kfB16ZOBjFC3lH2U5An+ yQYIIPZrSWXUeKjeMaKGvbg6W9Oi4XEtrwpzUGhbewxCZZCIrzAH2hz0dUhacxB201Y/faY6 BdTS75SPs+zjTYo8yE9Y9eG7x/lB60nQjJiZVNvZ88QDfVuLl/heuIq+fyNajBbqbtBT5CWf mOP4Dh4xjm3Vwlz8imWW/drEVJZJrPYqv0HdPbY8jVMpqoe5jDloyVn3prfLdXSbKPexlJaW 5tnPd4lj8rqOFShRnLFCibpeHWIumqrIqIkiRA9kFW3XMgtU6JkIrQzhJb6Tc6mZg2wuYW0d Wo2qvdziMgPkMFiWJpsxM9xPk9BBVwR+uojNq5LzdCsXQ2seG0dhaOTaaIDWVS8U/V8Nqjrl 6bGG2quo5YzJuXKjtKjZ4R6k762pHJ3tnzI/jnlc1sXz Message-ID: <1fb184b1-4304-fa39-cd04-0608ef996f50@pengutronix.de> Date: Tue, 3 Mar 2020 15:11:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200303140912.GH31977@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/3/20 3:09 PM, Andrew Lunn wrote: >>> Hi Oleksij, Heiner, Marc, >>> >>> You could also refer the solution implemented here as part of a TJA110x driver: >>> https://source.codeaurora.org/external/autoivnsw/tja110x_linux_phydev/about/ >> >> OK, thank you! >> >> Suddenly, the solution in this driver is not mainlainable. It may match on >> ther PHYs with PHYID == 0. >> >> See this part of the code: >> #define NXP_PHY_ID_TJA1102P1 (0x00000000U) >> ... >> , { >> .phy_id = NXP_PHY_ID_TJA1102P1, >> .name = "TJA1102_p1", >> .phy_id_mask = NXP_PHY_ID_MASK, > > Noooo > > You cannot assume NXP is the only silicon vendor to manufacture broken > silicon with a PHY ID of 0. ACK, we ruled that soultion out already :) We'll look into your and Marek's suggestions. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |