Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp3447275ybf; Tue, 3 Mar 2020 06:14:53 -0800 (PST) X-Google-Smtp-Source: ADFU+vtV+5NaQ08Twy5TCFN0UXeF9S4xHfrxC8vrve4QqJdRcTpd1KP85hEap5JIR8jDvGVPhYm3 X-Received: by 2002:a9d:6e15:: with SMTP id e21mr3413291otr.289.1583244893261; Tue, 03 Mar 2020 06:14:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583244893; cv=none; d=google.com; s=arc-20160816; b=N/qDLwtVoihZXbX4vNuRRF2FhBhWXhhy1mEv5gaBDWeJn61Q+GHEAI5DNImqXvulmb bsqYeyYUnHXS8JgvCrbgtSQUVEYm+qTWJSF63NtB7F7pJ4rGKHT/Nr20m/36PNezqTuM XtQGAJ4Ujubq1fCcK3qn82eDwkBhQ+0kn6B4/ug9sHVZvQ932SJl/OC9wLo+bH3B8Tpl KoI5nKFjl+vP8I0KbaKJsI00h9WtqUyTWJ0coO6RVmLIhLviwKk0COupFyLZ6Zd3ojZI kPRVPWcL/n7gFH5UYV4Vg4v8zg+n72I2uW2Sz8v2D3DpLgQ7g7A5SCVzkEV8WecrYQYt XcRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:organization:references:in-reply-to:subject:cc:to:from :date; bh=84zlYLdLumF30vOsS5LHUSBwbFhNLUKS106L0KCOeJg=; b=kz3cGeaXgN6mHiN9FUQoDGWGqXYrGpKUg14a6gEpUrx4JycaXj5TGEIxpuoDx0z8s9 Efo8QT5btB5dQCJ1VI5zFiALPRevpzA8TZNUyymDvoCx6+LT1PTkdnhA1pSE0GpOqCVM VS48gY8tow0mRAmleekVf2tJkGDz2dvxbTc8VFTieljgS9uKaRtWYoTieUE3ufrsZhIW e0McZE6rPI9r9pqmw5Ig9aQxF22xg64sKxINjFmZbvw7QgMHEl2MbZW2+aT7sxU3Zv2j hHhBNOe27VfjFH5VmnG1tNMCEVPOjKte57VZxfDfjRpHmGRNzkxBu4y1Xl+7/ic+8/sU e4aA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1si7993827otn.150.2020.03.03.06.14.40; Tue, 03 Mar 2020 06:14:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729013AbgCCONF (ORCPT + 99 others); Tue, 3 Mar 2020 09:13:05 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52598 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725932AbgCCOND (ORCPT ); Tue, 3 Mar 2020 09:13:03 -0500 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 023Du93Y137492 for ; Tue, 3 Mar 2020 09:13:02 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2yfmg19cnv-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 03 Mar 2020 09:13:01 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Mar 2020 14:12:58 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 3 Mar 2020 14:12:55 -0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 023ECrkS50069520 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 3 Mar 2020 14:12:54 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D75FC4204B; Tue, 3 Mar 2020 14:12:53 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6C2484203F; Tue, 3 Mar 2020 14:12:53 +0000 (GMT) Received: from oc2783563651 (unknown [9.152.224.80]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 3 Mar 2020 14:12:53 +0000 (GMT) Date: Tue, 3 Mar 2020 15:12:52 +0100 From: Halil Pasic To: "Michael S. Tsirkin" , Jason Wang Cc: Paolo Bonzini , Stefan Hajnoczi , Jens Axboe , virtualization@lists.linux-foundation.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Christian Borntraeger , Viktor Mihajlovski , Cornelia Huck , Ram Pai , Thiago Jung Bauermann , "Lendacky, Thomas" Subject: Re: [PATCH 0/2] virtio-blk: improve handling of DMA mapping failures In-Reply-To: <20200213123728.61216-1-pasic@linux.ibm.com> References: <20200213123728.61216-1-pasic@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 20030314-0020-0000-0000-000003B0199C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20030314-0021-0000-0000-000022084913 Message-Id: <20200303151252.59d45e86.pasic@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-03-03_04:2020-03-03,2020-03-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 clxscore=1015 lowpriorityscore=0 malwarescore=0 adultscore=0 suspectscore=0 priorityscore=1501 spamscore=0 mlxscore=0 bulkscore=0 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003030107 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Feb 2020 13:37:26 +0100 Halil Pasic wrote: > Two patches are handling new edge cases introduced by doing DMA mappings > (which can fail) in virtio core. > > I stumbled upon this while stress testing I/O for Protected Virtual > Machines. I deliberately chose a tiny swiotlb size and have generated > load with fio. With more than one virtio-blk disk in use I experienced > hangs. > > The goal of this series is to fix those hangs. > > Halil Pasic (2): > virtio-blk: fix hw_queue stopped on arbitrary error > virtio-blk: improve virtqueue error to BLK_STS > > drivers/block/virtio_blk.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > > base-commit: 39bed42de2e7d74686a2d5a45638d6a5d7e7d473 ping Hi Michael, hi Jason, I got some favorable reviews for this, but AFAIK I got nothing form the maintainers yet. Is some of you going to pick these? Regards, Halil