Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp3453399ybf; Tue, 3 Mar 2020 06:20:46 -0800 (PST) X-Google-Smtp-Source: ADFU+vsdkqPoFPjgJDXDLjiKB2xEqkNILu3i9qQwSJ3aFZoRb8OSP1feL3lvfb0lG3snUVzhuFmp X-Received: by 2002:a05:6830:2009:: with SMTP id e9mr3670379otp.296.1583245246838; Tue, 03 Mar 2020 06:20:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583245246; cv=none; d=google.com; s=arc-20160816; b=HRsWsaa/ZcqAGWMrCj0GPBpJFdoSKmmG0TTQiXd/Vf3VKyg6jsEtfG9JHaFVRyoUj/ WUAhhqseNzFioreJvDprkUjWmsg/tAPEAp+FB0zTEq+kGwgrfwQ1KIsThwPTYYxb3R81 iZy4CQItOJaDoggxxeMHX9o44WJKEPgigOu7FiTYhLi8EsCDpW1RRkKxnXhUTRGmgusO VFdSZ8r4FlI6hkB7x04NAqqRXxDErLnf+7w5mcYHBEUxLGLyEY9cwRhfZJgFawxlFZBs 2Jblxjer1ZjowYeMDTkcR3prb1Z7NUJu+X7GMqPom+vSCyDCdZgEYI56e6W+zd0ChuNM YvpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :dkim-signature; bh=gP09PkMcAbB+aqERIzsOakmbWC4dSi+WdMqM2DGrLiw=; b=axP78IdAJKjw2idtZi0rdNXAltW3WvfoXTZI+Ps6+ErkwZaagE0HHoK5+j+evFD+JE eTFic/gfn8Znbupr4OMonMn5rENo5U7MOCWAouhDIKPym4n4dz7kNDjwm6bk/Chg1syP 7a1ghUYJgrawra7jQ2K1/Py2weTK8hWIVeVkLkgWrE5QVkPU0PMekMH3WFF9VvUNzLeL SOYmnMkV/yduCJk0Mh94Ehxn2TQyQf+Xm1B1mikaUvmUkzX31aBDHLb4M+KSxvD5VHtO cAcIQrr1u6ah6ttKhF9GCj6MAKdrJvPpsylSx+RxCzdKCe0iVCs/GkT1FmpjYf9ABnlr soEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a0+yFjRB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f184si1849519oig.212.2020.03.03.06.20.33; Tue, 03 Mar 2020 06:20:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a0+yFjRB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728335AbgCCOUH (ORCPT + 99 others); Tue, 3 Mar 2020 09:20:07 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:42924 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727311AbgCCOUH (ORCPT ); Tue, 3 Mar 2020 09:20:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583245206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gP09PkMcAbB+aqERIzsOakmbWC4dSi+WdMqM2DGrLiw=; b=a0+yFjRBD0QTe5dbXgK8CcqR5OwXG4+TExXVz2Qs4HQd6wkVfduN6rseU84/GzJJNRqXXl 4fHjK0MJFitsiYAWCNHXNrejWH/9+qcF5BCSeR2pYiQgUjJ6D31JqDAodDop/aVV9mAvYi SAYWJsFqXjNe6s7/6ku1yuMbEdtTWds= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-487-12-YiS5SOA6KUj7hkxmUvw-1; Tue, 03 Mar 2020 09:20:04 -0500 X-MC-Unique: 12-YiS5SOA6KUj7hkxmUvw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 85E8E802698; Tue, 3 Mar 2020 14:20:02 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-182.rdu2.redhat.com [10.10.120.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD24D101D493; Tue, 3 Mar 2020 14:19:59 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20200303141030.GA2811@kroah.com> References: <20200303141030.GA2811@kroah.com> <0403cda7345e34c800eec8e2870a1917a8c07e5c.camel@themaw.net> <1509948.1583226773@warthog.procyon.org.uk> <20200303113814.rsqhljkch6tgorpu@ws.net.home> <20200303130347.GA2302029@kroah.com> <20200303131434.GA2373427@kroah.com> <20200303134316.GA2509660@kroah.com> To: Greg Kroah-Hartman Cc: dhowells@redhat.com, Miklos Szeredi , Karel Zak , Ian Kent , Christian Brauner , James Bottomley , Steven Whitehouse , Miklos Szeredi , viro , Christian Brauner , Jann Horn , "Darrick J. Wong" , Linux API , linux-fsdevel , lkml Subject: Re: [PATCH 00/17] VFS: Filesystem information and notifications [ver #17] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1657842.1583245198.1@warthog.procyon.org.uk> Date: Tue, 03 Mar 2020 14:19:58 +0000 Message-ID: <1657843.1583245198@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg Kroah-Hartman wrote: > + fd = do_sys_open(dfd, filename, flags, 0000); > + if (fd <= 0) > + return fd; > + > + retval = ksys_read(fd, buffer, bufsize); > + > + __close_fd(current->files, fd); If you can use dentry_open() and vfs_read(), you might be able to avoid dealing with file descriptors entirely. That might make it worth a syscall. You're going to be asked for writefile() you know ;-) David