Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CAKT=dDnFpj2hJd5z73pfcrhXXacDpPVyKzC7+K94tsX=+e_BHg@mail.gmail.com>
 <20200302235044.59163-1-zzyiwei@google.com> <20200303090703.32b2ad68@gandalf.local.home>
 <20200303141505.GA3405@kroah.com> <20200303093104.260b1946@gandalf.local.home>
In-Reply-To: <20200303093104.260b1946@gandalf.local.home>
From:   Yiwei Zhang <zzyiwei@google.com>
Date:   Tue, 3 Mar 2020 07:15:46 -0800
Message-ID: <CAKT=dD=a2r8s_ksHmwdOvnpKG0JeRxCo+ERzYGPFTW6OR01Org@mail.gmail.com>
Subject: Re: [PATCH v4] gpu/trace: add a gpu total memory usage tracepoint
To:     Greg KH <gregkh@linuxfoundation.org>,
        Steven Rostedt <rostedt@goodmis.org>
Cc:     mingo@redhat.com, elder@kernel.org, federico.vaga@cern.ch,
        tony.luck@intel.com, vilhelm.gray@gmail.com,
        Linus Walleij <linus.walleij@linaro.org>, tglx@linutronix.de,
        yamada.masahiro@socionext.com, paul.walmsley@sifive.com,
        bhelgaas@google.com, darekm@google.com,
        Nick Desaulniers <ndesaulniers@google.com>,
        Joel Fernandes <joelaf@google.com>,
        linux-kernel@vger.kernel.org,
        Prahlad Kilambi <prahladk@google.com>,
        android-kernel <android-kernel@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 3, 2020 at 6:31 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Tue, 3 Mar 2020 15:15:05 +0100
> Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > On Tue, Mar 03, 2020 at 09:07:03AM -0500, Steven Rostedt wrote:
> > >
> > > Greg,
> > >
> > > You acked this patch before, did you want to ack it again, and I'll take it
> > > in my tree?
> >
> > Sure, but where did my ack go?  What changed from previous versions???
> >
> > Anyway, the patch seems sane enough to me:
> >
> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Your previous ack was was here:
>
>   https://lore.kernel.org/lkml/20200213004029.GA2500609@kroah.com/
>
> And the patch changed since then (although, only cosmetically), so your ack
> was removed. The diff between this patch and the patch you acked is this:
>
> -- Steve
>
> diff --git a/include/trace/events/gpu_mem.h b/include/trace/events/gpu_mem.h
> index 3b632a2b5100..1897822a9150 100644
> --- a/include/trace/events/gpu_mem.h
> +++ b/include/trace/events/gpu_mem.h
> @@ -28,34 +28,27 @@
>   *
>   */
>  TRACE_EVENT(gpu_mem_total,
> -       TP_PROTO(
> -               uint32_t gpu_id,
> -               uint32_t pid,
> -               uint64_t size
> -       ),
> -       TP_ARGS(
> -               gpu_id,
> -               pid,
> -               size
> -       ),
> +
> +       TP_PROTO(uint32_t gpu_id, uint32_t pid, uint64_t size),
> +
> +       TP_ARGS(gpu_id, pid, size),
> +
>         TP_STRUCT__entry(
>                 __field(uint32_t, gpu_id)
>                 __field(uint32_t, pid)
>                 __field(uint64_t, size)
>         ),
> +
>         TP_fast_assign(
>                 __entry->gpu_id = gpu_id;
>                 __entry->pid = pid;
>                 __entry->size = size;
>         ),
> -       TP_printk(
> -               "gpu_id=%u "
> -               "pid=%u "
> -               "size=%llu",
> +
> +       TP_printk("gpu_id=%u pid=%u size=%llu",
>                 __entry->gpu_id,
>                 __entry->pid,
> -               __entry->size
> -       )
> +               __entry->size)
>  );
>
>  #endif /* _TRACE_GPU_MEM_H */

Hi Steve, since Greg has acknowledged again on the latest patch v4,
will you help merge from your tree?

Thanks for all the help!
Yiwei