Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp3548737ybf; Tue, 3 Mar 2020 07:58:01 -0800 (PST) X-Google-Smtp-Source: ADFU+vt47oQ4uo8BXDWUv/BxJGQGt7AGm5bHDZ4QDqHlMdVH+VIK0wdu46myNNH/vCLbzlnLmnYg X-Received: by 2002:a9d:7c9a:: with SMTP id q26mr4127959otn.206.1583251081418; Tue, 03 Mar 2020 07:58:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583251081; cv=none; d=google.com; s=arc-20160816; b=X2IiEcgS5bfv5MUj/1dTqY/doI78Ob5wfUNm6erNFlz1VmJYEVd/Ku8sFuJEybbOj2 tK8QrkZbFqyCDNv6oGdHJYaPW8tZ8iyDK9MgFyPZdyc7yh1sy4ctwvzLsA+PFJuS/Fjr Y2Hpsw7EoXcwVVcgE1aLEMvvmGT6xWBKdSwz0sZYFOQ7PstJvr9XB3g+yG7S9PT2ayda e65w2U+NUbgRbpgyjYtP/yIWL476uhqj0JQZZxRqKmnpLCIYM7rmaR/N4Rtwzrgo5ldJ 2kGs7vNIxaLK6Y0k31n4XegwL0ltnGwa9/74Wi/s45ftkKA7WUFHak3uXK9TUyPdijO+ zw7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=wUChkrPr5ljfTasjojcfSOHYLssa67n/JsN8CgfdAHE=; b=CMYAYyhCkNcmi239nqbGticm7Api6FMI9NWm2X3inc7BiI6/BEG6j7qr4Qa2wM89IT ddREFn4i8Vm5yUGK/nVEQAHa5uls7bK45WRKgfMFTA1BqIkL53z+Od7rM1VtnR6dx4ka UmR0EtaShxdAFVD6noEz/IiB1ume1Qwi1QzeixfKxjUpuVgdacnNlCtpWLfqQo4UiLws DJ69r5CF1VfEwJL3uhxRtHZ1qnCSk9n5U9Varbg6R7fuctdHsEeDiY8DoXfAJ2TWENNd LZ28a1QJm4dVonVQkbI+E2vtOHRcuzg3aL+9wh1pneo0k2rmgvpbIiYAY26geKDrofhA DhdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=K9XNUJGr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p12si8524790otk.173.2020.03.03.07.57.49; Tue, 03 Mar 2020 07:58:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=K9XNUJGr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730230AbgCCPuG (ORCPT + 99 others); Tue, 3 Mar 2020 10:50:06 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:33286 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727683AbgCCPuG (ORCPT ); Tue, 3 Mar 2020 10:50:06 -0500 Received: by mail-ed1-f66.google.com with SMTP id c62so5051436edf.0 for ; Tue, 03 Mar 2020 07:50:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wUChkrPr5ljfTasjojcfSOHYLssa67n/JsN8CgfdAHE=; b=K9XNUJGroYRdDR1ux6pXF7oQJcGzvpLxnCKPCsX26C0Tu9hC5HuWWrFU7srbEOJOL+ Jk8ookxlAbji14BsL73PDTTF5eIJrpdAnDiCpyDiRGGvFozH6M+B80Uy/Fe1JxlrrsXH GRW1RIhoPUEdNvwHY5SmG3qe3uwWBJBypBRAE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wUChkrPr5ljfTasjojcfSOHYLssa67n/JsN8CgfdAHE=; b=bE3rvOgReC7Pnazg18WSyBuAi7XKoRWf90DiLjPc1LDuC/suX5Lr8CLtuJLUY0SbV+ YSjQe3gc6dMEBt15lYpkpGcw4XXzC5omE9lPb2X9O0043JGcY95fQFYKsqTKd02N4CML qjTiiR+sIJXbrY0RVsKS6iUYsPEJriqhkbdbZmnELoeeabFXEL2XtXMZr74DKdGbElox fmJlZHjJiOxOvrAzWvnf26uofVujjr9V3bAvB9eSoD9HgUdXqxGXPLnuWw5MPaHTooJQ PtFuR3kbIfoNsWVhdAMi/HbjbAc/K+W6bDX9CkgSY++NjD55xjBiVLjNWLOeNVW6EhV/ PPKQ== X-Gm-Message-State: ANhLgQ0qz38K6TnCCuGtkUS40ZgH37w/EKICcKII0nlQofJ9UUHDJXSN QbamiKulJN6sMXzW9RAt/BO++4/6rT8= X-Received: by 2002:a05:6402:c02:: with SMTP id co2mr2678858edb.72.1583250604338; Tue, 03 Mar 2020 07:50:04 -0800 (PST) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com. [209.85.128.49]) by smtp.gmail.com with ESMTPSA id m6sm1050164ejb.51.2020.03.03.07.50.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2020 07:50:04 -0800 (PST) Received: by mail-wm1-f49.google.com with SMTP id a25so2662611wmm.0 for ; Tue, 03 Mar 2020 07:50:04 -0800 (PST) X-Received: by 2002:a7b:c416:: with SMTP id k22mr4837344wmi.88.1583250223087; Tue, 03 Mar 2020 07:43:43 -0800 (PST) MIME-Version: 1.0 References: <20200228000105.165012-1-thgarnie@chromium.org> <202003022100.54CEEE60F@keescook> <20200303095514.GA2596@hirez.programming.kicks-ass.net> In-Reply-To: <20200303095514.GA2596@hirez.programming.kicks-ass.net> From: Thomas Garnier Date: Tue, 3 Mar 2020 07:43:31 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v11 00/11] x86: PIE support to extend KASLR randomization To: Peter Zijlstra Cc: Kees Cook , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Kernel Hardening , Kristen Carlson Accardi , Herbert Xu , "David S. Miller" , "H. Peter Anvin" , "the arch/x86 maintainers" , Andy Lutomirski , Juergen Gross , Thomas Hellstrom , "VMware, Inc." , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Rasmus Villemoes , Miguel Ojeda , Will Deacon , Ard Biesheuvel , Masami Hiramatsu , Jiri Slaby , Boris Ostrovsky , Josh Poimboeuf , Cao jin , Allison Randal , Linux Crypto Mailing List , LKML , virtualization@lists.linux-foundation.org, Linux PM list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 3, 2020 at 1:55 AM Peter Zijlstra wrote: > > On Mon, Mar 02, 2020 at 09:02:15PM -0800, Kees Cook wrote: > > On Thu, Feb 27, 2020 at 04:00:45PM -0800, Thomas Garnier wrote: > > > Minor changes based on feedback and rebase from v10. > > > > > > Splitting the previous serie in two. This part contains assembly code > > > changes required for PIE but without any direct dependencies with the > > > rest of the patchset. > > > > > > Note: Using objtool to detect non-compliant PIE relocations is not yet > > > possible as this patchset only includes the simplest PIE changes. > > > Additional changes are needed in kvm, xen and percpu code. > > > > > > Changes: > > > - patch v11 (assembly); > > > - Fix comments on x86/entry/64. > > > - Remove KASLR PIE explanation on all commits. > > > - Add note on objtool not being possible at this stage of the patchset. > > > > This moves us closer to PIE in a clean first step. I think these patches > > look good to go, and unblock the work in kvm, xen, and percpu code. Can > > one of the x86 maintainers pick this series up? > > But,... do we still need this in the light of that fine-grained kaslr > stuff? > > What is the actual value of this PIE crud in the face of that? If I remember well, it makes it easier/better but I haven't seen a recent update on that. Is that accurate Kees?