Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 3 Mar 2020 16:56:39 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     zzyiwei@google.com, mingo@redhat.com, elder@kernel.org,
        federico.vaga@cern.ch, tony.luck@intel.com, vilhelm.gray@gmail.com,
        linus.walleij@linaro.org, tglx@linutronix.de,
        yamada.masahiro@socionext.com, paul.walmsley@sifive.com,
        bhelgaas@google.com, darekm@google.com, ndesaulniers@google.com,
        joelaf@google.com, linux-kernel@vger.kernel.org,
        prahladk@google.com, android-kernel@google.com
Subject: Re: [PATCH v4] gpu/trace: add a gpu total memory usage tracepoint
Message-ID: <20200303155639.GA437469@kroah.com>
References: <CAKT=dDnFpj2hJd5z73pfcrhXXacDpPVyKzC7+K94tsX=+e_BHg@mail.gmail.com>
 <20200302235044.59163-1-zzyiwei@google.com>
 <20200303090703.32b2ad68@gandalf.local.home>
 <20200303141505.GA3405@kroah.com>
 <20200303093104.260b1946@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200303093104.260b1946@gandalf.local.home>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 03, 2020 at 09:31:04AM -0500, Steven Rostedt wrote:
> On Tue, 3 Mar 2020 15:15:05 +0100
> Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> > On Tue, Mar 03, 2020 at 09:07:03AM -0500, Steven Rostedt wrote:
> > > 
> > > Greg,
> > > 
> > > You acked this patch before, did you want to ack it again, and I'll take it
> > > in my tree?  
> > 
> > Sure, but where did my ack go?  What changed from previous versions???
> > 
> > Anyway, the patch seems sane enough to me:
> > 
> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Your previous ack was was here:
> 
>   https://lore.kernel.org/lkml/20200213004029.GA2500609@kroah.com/

Yeah, I remember that.

> And the patch changed since then (although, only cosmetically), so your ack
> was removed. The diff between this patch and the patch you acked is this:
> 
> -- Steve
> 
> diff --git a/include/trace/events/gpu_mem.h b/include/trace/events/gpu_mem.h
> index 3b632a2b5100..1897822a9150 100644
> --- a/include/trace/events/gpu_mem.h
> +++ b/include/trace/events/gpu_mem.h
> @@ -28,34 +28,27 @@
>   *
>   */
>  TRACE_EVENT(gpu_mem_total,
> -	TP_PROTO(
> -		uint32_t gpu_id,
> -		uint32_t pid,
> -		uint64_t size
> -	),
> -	TP_ARGS(
> -		gpu_id,
> -		pid,
> -		size
> -	),
> +
> +	TP_PROTO(uint32_t gpu_id, uint32_t pid, uint64_t size),
> +
> +	TP_ARGS(gpu_id, pid, size),
> +
>  	TP_STRUCT__entry(
>  		__field(uint32_t, gpu_id)
>  		__field(uint32_t, pid)
>  		__field(uint64_t, size)
>  	),
> +
>  	TP_fast_assign(
>  		__entry->gpu_id = gpu_id;
>  		__entry->pid = pid;
>  		__entry->size = size;
>  	),
> -	TP_printk(
> -		"gpu_id=%u "
> -		"pid=%u "
> -		"size=%llu",
> +
> +	TP_printk("gpu_id=%u pid=%u size=%llu",
>  		__entry->gpu_id,
>  		__entry->pid,
> -		__entry->size
> -	)
> +		__entry->size)
>  );
>  
>  #endif /* _TRACE_GPU_MEM_H */

thanks for the diff, my ack still stands.

greg k-h