Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 2/2] arm64: dts: rockchip: Add initial support for
 Pinebook Pro
From:   Johan Jonker <jbx6244@gmail.com>
To:     Tobias Schramm <t.schramm@manjaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Andy Yan <andy.yan@rock-chips.com>
Cc:     Douglas Anderson <dianders@chromium.org>,
        Jagan Teki <jagan@amarulasolutions.com>,
        Markus Reichl <m.reichl@fivetechno.de>,
        Alexis Ballier <aballier@gentoo.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        Nick Xie <nick@khadas.com>,
        Kever Yang <kever.yang@rock-chips.com>,
        Vivek Unune <npcomplete13@gmail.com>,
        Katsuhiro Suzuki <katsuhiro@katsuster.net>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
        Vasily Khoruzhick <anarsoul@gmail.com>
References: <20200229144817.355678-1-t.schramm@manjaro.org>
 <20200229144817.355678-3-t.schramm@manjaro.org>
 <bcc2c8d4-a2cd-58c1-89af-e42439f8f344@gmail.com>
Message-ID: <850e60b0-c260-c184-839f-93b064388e32@gmail.com>
Date:   Tue, 3 Mar 2020 17:11:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <bcc2c8d4-a2cd-58c1-89af-e42439f8f344@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

Add more reg = <..>

On 3/3/20 4:37 PM, Johan Jonker wrote:
> Hi Tobias,
> 
> Some minor style issues.
> This dts file contains a partition node.
> Question for the maintainers (Heiko?):
> Should that partition be included or not?

[..]

>> +&i2c4 {
>> +	i2c-scl-falling-time-ns = <20>;
>> +	i2c-scl-rising-time-ns = <600>;
>> +	status = "okay";
>> +
>> +	fusb0: fusb30x@22 {
>> +		compatible = "fcs,fusb302";
>> +		reg = <0x22>;
>> +		fcs,int_n = <&gpio1 RK_PA2 GPIO_ACTIVE_HIGH>;
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&fusb0_int_gpio>;
> 
>> +		status = "okay";
> 
> Remove or else status below.
> New nodes are already okay I think.
> If insure check compiled flat dts output to see if it is still there.
> 
>> +		vbus-supply = <&vbus_typec>;
>> +
>> +		connector {
>> +			compatible = "usb-c-connector";
>> +			label = "USB-C";
>> +			op-sink-microwatt = <1000000>;
>> +			power-role = "dual";
>> +			sink-pdos =
>> +				<PDO_FIXED(5000, 2500, PDO_FIXED_USB_COMM)>;
>> +			source-pdos =
>> +				<PDO_FIXED(5000, 1400, PDO_FIXED_USB_COMM)>;
>> +			try-power-role = "sink";
>> +
>> +			ports {
>> +				#address-cells = <1>;
>> +				#size-cells = <0>;
>> +
>> +				port@0 {

reg = <0>;

>> +					usbc_hs: endpoint {
>> +						remote-endpoint =
>> +							<&u2phy0_typec_hs>;
>> +					};
>> +				};
>> +
>> +				port@1 {

reg = <1>;

>> +					usbc_ss: endpoint {
>> +						remote-endpoint =
>> +							<&tcphy0_typec_ss>;
>> +					};
>> +				};
>> +
>> +				port@2 {

reg = <2>;

>> +					usbc_dp: endpoint {
>> +						remote-endpoint =
>> +							<&tcphy0_typec_dp>;
>> +					};
>> +				};
>> +			};
>> +		};
>> +	};
>> +};