Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 3/3] perf vendor events amd: update Zen1 events to V2
To:     Vijay Thakkar <vijaythakkar@me.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        =?UTF-8?Q?Martin_Li=c5=a1ka?= <mliska@suse.cz>,
        Jon Grimm <jon.grimm@amd.com>, linux-kernel@vger.kernel.org,
        linux-perf-users@vger.kernel.org
References: <20200228175639.39171-1-vijaythakkar@me.com>
 <20200228175639.39171-4-vijaythakkar@me.com>
From:   Kim Phillips <kim.phillips@amd.com>
Message-ID: <77552e9e-7fca-7186-24cc-6a8a87d4b7b6@amd.com>
Date:   Tue, 3 Mar 2020 11:04:23 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
In-Reply-To: <20200228175639.39171-4-vijaythakkar@me.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.236.136.247] (165.204.77.1) by DM5PR22CA0012.namprd22.prod.outlook.com (2603:10b6:3:101::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.14 via Frontend Transport; Tue, 3 Mar 2020 17:04:24 +0000
X-Originating-IP: [165.204.77.1]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 4785c8fc-37ee-4c95-f512-08d7bf94ed7f
X-MS-TrafficTypeDiagnostic: SN6PR12MB2671:|SN6PR12MB2671:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <SN6PR12MB267187C79D372610E589528887E40@SN6PR12MB2671.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4941;
X-Forefront-PRVS: 03319F6FEF
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(366004)(396003)(39860400002)(346002)(376002)(189003)(199004)(8936002)(7416002)(66476007)(81166006)(31696002)(5660300002)(81156014)(4326008)(6486002)(86362001)(8676002)(66946007)(66556008)(53546011)(52116002)(36756003)(110136005)(31686004)(16576012)(16526019)(54906003)(316002)(26005)(2906002)(2616005)(956004)(478600001)(186003)(44832011);DIR:OUT;SFP:1101;SCL:1;SRVR:SN6PR12MB2671;H:SN6PR12MB2845.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: e5JhFpE0IYvrCu5keJ6NvKH/bZCM+bX/S9ya551RIPfJbSoYxECboCsjyVY+0Xd1BYa/DiR1Mv+eQmAb8N7ibuqBPIzFLNaKzwPzuQPwWeonsHeJS95ituq1amEZaCcRAqBWTAn9Mm74pJKuU8/5zPQ6/oNxRNNCG5ffaudKvsnmodRcPPKy/xPFIhGH4BpSgockeKh/NXRBWlEfGPutB56Q02BcGLkvnhimIDKb4qWSg6RAVKA+wBHihSYWESzBUej3nuDmhjdWJJEJ0oZkqDz8NfPZVCT/PQxYshDjrLS5q5C5CMWxSFfLPSjLRTyK7qlbAt7A8bBP22sHEvpPAwOTD0u+Du6zo1nZq3aQFFoHZvVRcYa1hNEAItZAD9n9z921B8Cbibo0Dut3MaKQgGtXat26K1xVl6Xr8EPnNLi9SLCzz8/WZ7lbeA1fmbCk
X-MS-Exchange-AntiSpam-MessageData: xbfVOTlU383yu+JfbBhPKLB0i6Jon3uczQHY3BAuAtXgTFTo2vXfirX8FFmIwbze3nBAYyeDEQmc/HfR7ZjeLJXAGmjXoAZm/VWnJEllKPCAFhvHgW8svlDubCMY9v758wPVckZcR7NC/ahXngYztg==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4785c8fc-37ee-4c95-f512-08d7bf94ed7f
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2020 17:04:25.8757
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C0HAFfzkJ3iRF3QS2wY++XUhnmWMBmrhPTUO9SInWILnGsU19skK75SaOXyU481XZCdGFuvtC7UzzBm/QDj5Eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2671
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vijay,

On 2/28/20 11:56 AM, Vijay Thakkar wrote:
> +++ b/tools/perf/pmu-events/arch/x86/amdzen1/floating-point.json
> @@ -3,16 +3,72 @@
>      "EventName": "fpu_pipe_assignment.dual",
>      "EventCode": "0x00",
>      "BriefDescription": "Total number multi-pipe uOps.",

Please concatenate .."assigned to all pipes", like you did in the publicDescription:

> -    "PublicDescription": "The number of operations (uOps) and dual-pipe uOps dispatched to each of the 4 FPU execution pipelines. This event reflects how busy the FPU pipelines are and may be used for workload characterization. This includes all operations performed by x87, MMX, and SSE instructions, including moves. Each increment represents a one- cycle dispatch event. This event is a speculative event. Since this event includes non-numeric operations it is not suitable for measuring MFLOPS. Total number multi-pipe uOps assigned to Pipe 3.",
> +    "PublicDescription": "The number of operations (uOps) and dual-pipe uOps dispatched to each of the 4 FPU execution pipelines. This event reflects how busy the FPU pipelines are and may be used for workload characterization. This includes all operations performed by x87, MMX, and SSE instructions, including moves. Each increment represents a one- cycle dispatch event. This event is a speculative event. Since this event includes non-numeric operations it is not suitable for measuring MFLOPS. Total number multi-pipe uOps assigned to all pipes.",
>      "UMask": "0xf0"
>    },
<snip>
>    {
>      "EventName": "fpu_pipe_assignment.total",
>      "EventCode": "0x00",
>      "BriefDescription": "Total number uOps.",

Same here.

> -    "PublicDescription": "The number of operations (uOps) and dual-pipe uOps dispatched to each of the 4 FPU execution pipelines. This event reflects how busy the FPU pipelines are and may be used for workload characterization. This includes all operations performed by x87, MMX, and SSE instructions, including moves. Each increment represents a one- cycle dispatch event. This event is a speculative event. Since this event includes non-numeric operations it is not suitable for measuring MFLOPS. Total number uOps assigned to Pipe 3.",
> +    "PublicDescription": "The number of operations (uOps) and dual-pipe uOps dispatched to each of the 4 FPU execution pipelines. This event reflects how busy the FPU pipelines are and may be used for workload characterization. This includes all operations performed by x87, MMX, and SSE instructions, including moves. Each increment represents a one- cycle dispatch event. This event is a speculative event. Since this event includes non-numeric operations it is not suitable for measuring MFLOPS. Total number uOps assigned to all pipes.",
>      "UMask": "0xf"
>    },

The rest looks good to me, and so does patch 1/3 still.

Thanks,

Kim