Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Bird, Tim" <Tim.Bird@sony.com>
To:     Jonathan Corbet <corbet@lwn.net>,
        "tbird20d@gmail.com" <tbird20d@gmail.com>
CC:     "mchehab@kernel.org" <mchehab@kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] scripts/sphinx-pre-install: add '-p python3' to
 virtualenv
Thread-Topic: [PATCH] scripts/sphinx-pre-install: add '-p python3' to
 virtualenv
Thread-Index: AQHV63v40W4+vR3Xqky9SMj7WmB1Yag1xeiAgAFeC7A=
Date:   Tue, 3 Mar 2020 17:07:48 +0000
Message-ID: <MWHPR13MB0895EFDA9EBF7740875E661CFDE40@MWHPR13MB0895.namprd13.prod.outlook.com>
References: <1582594481-23221-1-git-send-email-tim.bird@sony.com>
 <20200302130911.05a7e465@lwn.net>
In-Reply-To: <20200302130911.05a7e465@lwn.net>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: sony.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ff08347-6d84-48bc-6171-08d7bf9566de
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2020 17:07:48.8969
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 66c65d8a-9158-4521-a2d8-664963db48e4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cNi7RzWCvnmF/PkCRMql9GpM//kuuIOapu2AqDPdWemlbdByc3sd5Jaug0zwt8X4ZQj32OxH4a0mhUBHBj03YQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR13MB1005
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Jonathan Corbet <corbet@lwn.net>
>=20
> On Mon, 24 Feb 2020 18:34:41 -0700
> tbird20d@gmail.com wrote:
>=20
> > With Ubuntu 16.04 (and presumably Debian distros of the same age),
> > the instructions for setting up a python virtual environment should
> > do so with the python 3 interpreter.  On these older distros, the
> > default python (and virtualenv command) might be python2 based.
> >
> > Some of the packages that sphinx relies on are now only available
> > for python3.  If you don't specify the python3 interpreter for
> > the virtualenv, you get errors when doing the pip installs for
> > various packages
> >
> > Fix this by adding '-p python3' to the virtualenv recommendation
> > line.
> >
> > Signed-off-by: Tim Bird <tim.bird@sony.com>
>=20
> I've applied this, even though it feels a bit fragile to me.  But Python
> stuff can be a bit that way, sometimes, I guess.

I agree it seems a bit wonky.
The less fragile approach would have been to just
always add the '-p python3' option to the virtualenv setup hint,
but Mauro seemed to want something more fine-tuned.
As far as the string parsing goes, I think that the format of strings
returned by lsb-release (and the predecesors that sphinx_pre_install
checks) is unlikely to change.

Thanks for applying it.
 -- Tim