Received: by 2002:a17:90a:9307:0:0:0:0 with SMTP id p7csp3946069pjo; Tue, 3 Mar 2020 09:54:01 -0800 (PST) X-Google-Smtp-Source: ADFU+vt2jN6RbaIJuezdWRAbeFiG6GH1LDJQClUpdRXPQKBl1L14RZ+9Z8EjuTKl1aRQS/vuHExb X-Received: by 2002:a05:6808:7dd:: with SMTP id f29mr3329105oij.67.1583258041012; Tue, 03 Mar 2020 09:54:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583258041; cv=none; d=google.com; s=arc-20160816; b=g7RP/zCDMKDkZGOftuycmjpOS0ZjOf1EMpAR/xiPsBZdEpTCCHHnLhSSpYY2ajBRrI 3KF+rpdfhi7FDvldRppReUxx1HO6EBBf9u0JYFa3FOqarkcPaP0sGUnEP1+purgaecOo lJoBkTDlg1WOyVlAK1vfDktwia/sslYLyN0Ju/VeTs6/hZ/MPuJN3Ab2GJ/wUDTUJC7u CpxmcCVgA0mVR0RtxIY7vxqmyp7meYZilItyn5XXW79ZAFDahFePH/9+68hS8XDPOOXD SGIus6llOotzrdZx87d4mlo3EIzYL8j/B2fawZfdZ4yITcqKVu7S9/huZVbCKVgqM0An sbkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fNUuawH/COijTcuFB9nPDcYdBVnukLR/sTQHM2N1rxU=; b=bcDwP0BudFH9TlcVVstv5EIIyVV8qqFbVM4Q7kAf0y0eXoWECCjolalfgUp8fATNKu vt5sHY4jPLU/OcgWHLd0k1uE2SEuKO4FHD87ztN2OQ4cxBpvLI+FMAq1kXCH+523wfh8 yuJJ98bWGmfS80nFKGOtZw9FT/OnY0V2PZa2bCyDT9rrnuNTdTTnCC71FnVy+P43FBhy QKv6F9Qbh+MzeMyEAnaFFHsRr69S0ZOyNkOowHIy/zOZo1Sjjr5HcY88NcjrhZE+YWx9 BoOKjVk5JmKAb2Nf39BmVJFg78EOvl1Fwr6j5rbCMbz64C24pdpcguZ1I4Wrg6m88ubT wXBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zuRUinfx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s207si7087095oih.255.2020.03.03.09.53.48; Tue, 03 Mar 2020 09:54:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zuRUinfx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732304AbgCCRxI (ORCPT + 99 others); Tue, 3 Mar 2020 12:53:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:33488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731343AbgCCRxD (ORCPT ); Tue, 3 Mar 2020 12:53:03 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BF0BF2072D; Tue, 3 Mar 2020 17:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583257983; bh=7/tLskozrg4ixBT/OquLc2xq33BKnTZdZEOZh32dCUw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zuRUinfxXMHz0L8eeWtZJp7PR9ZLwHNnMigI32t7ZpCRPU1zemt46g2iV7YrEC0Yw NcyM0mJmn20J84hl2ojNRDY/CGobGZfR2uaulsYdGiOdOFQPeAkFVfjm0iF/zn5mgn 9WcLLBn5LhOd5bfxUDJ6BVy1YJK1B1qnYV9guefQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jeff Moyer , Christoph Hellwig , Jan Kara , Dan Williams , Sasha Levin Subject: [PATCH 5.4 027/152] dax: pass NOWAIT flag to iomap_apply Date: Tue, 3 Mar 2020 18:42:05 +0100 Message-Id: <20200303174305.537006772@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200303174302.523080016@linuxfoundation.org> References: <20200303174302.523080016@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeff Moyer [ Upstream commit 96222d53842dfe54869ec4e1b9d4856daf9105a2 ] fstests generic/471 reports a failure when run with MOUNT_OPTIONS="-o dax". The reason is that the initial pwrite to an empty file with the RWF_NOWAIT flag set does not return -EAGAIN. It turns out that dax_iomap_rw doesn't pass that flag through to iomap_apply. With this patch applied, generic/471 passes for me. Signed-off-by: Jeff Moyer Reviewed-by: Christoph Hellwig Reviewed-by: Jan Kara Link: https://lore.kernel.org/r/x49r1z86e1d.fsf@segfault.boston.devel.redhat.com Signed-off-by: Dan Williams Signed-off-by: Sasha Levin --- fs/dax.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/dax.c b/fs/dax.c index 2cc43cd914eb8..cc56313c6b3b9 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -1207,6 +1207,9 @@ dax_iomap_rw(struct kiocb *iocb, struct iov_iter *iter, lockdep_assert_held(&inode->i_rwsem); } + if (iocb->ki_flags & IOCB_NOWAIT) + flags |= IOMAP_NOWAIT; + while (iov_iter_count(iter)) { ret = iomap_apply(inode, pos, iov_iter_count(iter), flags, ops, iter, dax_iomap_actor); -- 2.20.1