Received: by 2002:a17:90a:9307:0:0:0:0 with SMTP id p7csp3946389pjo; Tue, 3 Mar 2020 09:54:23 -0800 (PST) X-Google-Smtp-Source: ADFU+vshgS0Z6kjYiBT6T/VVs4+iuENbvJfxv+hozHJXw9FMww43v9bxbz7e41b45qukuYAuhMVv X-Received: by 2002:a05:6830:1d5:: with SMTP id r21mr4517669ota.54.1583258063128; Tue, 03 Mar 2020 09:54:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583258063; cv=none; d=google.com; s=arc-20160816; b=BkSv4o82qMeblcCD79DQbBT+ab3UcMFt8y5YTrHMps3IvL5PCRkhRoRe9zLTIxHmFu +DEBEJq9BZuoUmFh+tw5xLHNj1B5h4KeDF5esUqcbFTsno6DPmFqFJmOk/z0utFrIXg8 yzwWwHxmO5/6dNW6YnQBBJZ9eDvURECtFbh1eE/oy5qREI2y9/+x+/Hj58GpW4vm0m1b riVaUceyT8fnn1CLE8i4kaewMMTCIcdmGF5/0axenniPgDhLbqJ4SLIqoGs4giFQdctc QMwDQoTmPFB9Dxk24Ql6Uc6xe8u3SYoagtbYIznxP3cav7ukbK3mxxA9kf/rTanvO2w4 CJTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=F9/BljkuKrINAvIUrzOjUa11YL5TTrmsZdT7Nj5lLoE=; b=NE9DkzroqFUrwkGL8ReXxC/U40xlxwcPGDrVkv6IWqvRufYaxmL4OacOQKdtCdMCXR OsaK7qMrHlghG+09r2GFUD8BorgAztQoazurf3hIXNPaAZHZxscjvqEK5mM4mutCCHOV oOa0gTYE9tkHAx/efK7qNGq+M0SgdBnExgYBTu1v1mgJyfMCK08pSA5nWyGR1c+4cUj7 aeKCVBqwcJVKZFLp7p3KQYj7zoQoeyhF7UOY/eZimXqIdKd5nE1K0lZf2guAnJ6gUOXp T7d8JQifeUchNFQRwvG2G8OMp69WuXEbAH7ipT9FtfVXoL6ApE81t/btfJOHmzrl/Bmh F4ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FpoV67nf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t26si837937otc.205.2020.03.03.09.54.10; Tue, 03 Mar 2020 09:54:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FpoV67nf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732378AbgCCRx2 (ORCPT + 99 others); Tue, 3 Mar 2020 12:53:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:33946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732369AbgCCRx1 (ORCPT ); Tue, 3 Mar 2020 12:53:27 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2034E2072D; Tue, 3 Mar 2020 17:53:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583258005; bh=7owaZk17bIn9LmORoSnigHfR+cQw1OAbEYXdXpklBJg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FpoV67nfaUVkL0F3+udYbB8Hg/Qd3qoBhK7ZMP+7R12VHf1wnWfWIHTfReAfeJbGA Y9mPFUmQr1ag1V0Th4Fd3gdB5D3zQM90+lDBW6qqxuxZJPt1QRSJEoIFWyjFT1vxYa Fiq4XOx5aYfYJS7bAZ73SKFioUACcHPkB0jxP7gw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Robin Murphy , John Garry , Will Deacon , Sasha Levin Subject: [PATCH 5.4 034/152] perf/smmuv3: Use platform_get_irq_optional() for wired interrupt Date: Tue, 3 Mar 2020 18:42:12 +0100 Message-Id: <20200303174306.327208240@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200303174302.523080016@linuxfoundation.org> References: <20200303174302.523080016@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: John Garry [ Upstream commit 0ca2c0319a7bce0e152b51b866979d62dc261e48 ] Even though a SMMUv3 PMCG implementation may use an MSI as the form of interrupt source, the kernel would still complain that it does not find the wired (GSIV) interrupt in this case: root@(none)$ dmesg | grep arm-smmu-v3-pmcg | grep "not found" [ 59.237219] arm-smmu-v3-pmcg arm-smmu-v3-pmcg.8.auto: IRQ index 0 not found [ 59.322841] arm-smmu-v3-pmcg arm-smmu-v3-pmcg.9.auto: IRQ index 0 not found [ 59.422155] arm-smmu-v3-pmcg arm-smmu-v3-pmcg.10.auto: IRQ index 0 not found [ 59.539014] arm-smmu-v3-pmcg arm-smmu-v3-pmcg.11.auto: IRQ index 0 not found [ 59.640329] arm-smmu-v3-pmcg arm-smmu-v3-pmcg.12.auto: IRQ index 0 not found [ 59.743112] arm-smmu-v3-pmcg arm-smmu-v3-pmcg.13.auto: IRQ index 0 not found [ 59.880577] arm-smmu-v3-pmcg arm-smmu-v3-pmcg.14.auto: IRQ index 0 not found [ 60.017528] arm-smmu-v3-pmcg arm-smmu-v3-pmcg.15.auto: IRQ index 0 not found Use platform_get_irq_optional() to silence the warning. If neither interrupt source is found, then the driver will still warn that IRQ setup errored and the probe will fail. Reviewed-by: Robin Murphy Signed-off-by: John Garry Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- drivers/perf/arm_smmuv3_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/perf/arm_smmuv3_pmu.c b/drivers/perf/arm_smmuv3_pmu.c index 191f410cf35cd..2f8787276d9b8 100644 --- a/drivers/perf/arm_smmuv3_pmu.c +++ b/drivers/perf/arm_smmuv3_pmu.c @@ -772,7 +772,7 @@ static int smmu_pmu_probe(struct platform_device *pdev) smmu_pmu->reloc_base = smmu_pmu->reg_base; } - irq = platform_get_irq(pdev, 0); + irq = platform_get_irq_optional(pdev, 0); if (irq > 0) smmu_pmu->irq = irq; -- 2.20.1