Received: by 2002:a17:90a:9307:0:0:0:0 with SMTP id p7csp3958147pjo; Tue, 3 Mar 2020 10:05:39 -0800 (PST) X-Google-Smtp-Source: ADFU+vsAvYGKRNMoHJ6n44KrvnO2L6CAHsgX/YZdaYNUGe4g+b/TSLUtpomKy0nuPpZbAr/hAZmg X-Received: by 2002:a05:6830:1e76:: with SMTP id m22mr4501786otr.295.1583258739108; Tue, 03 Mar 2020 10:05:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583258739; cv=none; d=google.com; s=arc-20160816; b=dtITeWjyOnLoD89wGz0ayxJWSgyxAOS5rW7REys6Tv0ZRLuZlDyyowl5oav7nYeA37 G+MOVXHZCI3dtoaPY4DrM3HVT3hkEqK4NXsMPs22xBij5ynlaFy8w7KCiHRJAxHfzIQv aA6XL95qEpm6hAwk9uIX8nmeaL6cTzXIUWIoB+5G+WeVBfwflRIOavEkQ2igUY3sb/0c IXln6deW2ocljCEWLaCVqwK2so/p9d+RwUGNzkVBWCVVlP210FWYI/aihni38+2UI0P5 rwrbcIvyOQsq0Itouj3lZiVWbPdXSSIKJDg+FFlPIfXjcov5A6gyfNQwtWAEkL9VVcVi 7OpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZndGPesXZLJNczNaoD4Kp44CqunxNkIRT/YXco5N8pE=; b=BCDA5GYbttJsYOLOtkpa+nSZ5MNa7HkIrIFbaFj0jNcdrJFWfTWMqWT18tPzz+pmuL 7HYlMeuExAJLuju1WgsmizQvxKhXt51pvSq771+UNF0nma5YDNHQCC0Ipu7xJxf2Gtsr Q5NlDJXHiyfNwDbdxNJuq0i+qhILMkTyfQ8AooMI6dfGiJnChLka+3Ki5+2Lm2EpaqNu ECIRLirQQ0dSVPoji244gNP2beiPnMAJr1s4ZBn9iNPtqq8qlxhbXFD00BW3XTLWJB8i HC70BrKbQggFWeyiiesi223/Ac67lfHAxS+DiBfwo+5khn6o/+mN4QJKQ2Xh2sffxHJa ZaFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=U7ght9gu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v5si5946108ota.39.2020.03.03.10.05.26; Tue, 03 Mar 2020 10:05:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=U7ght9gu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387952AbgCCSEj (ORCPT + 99 others); Tue, 3 Mar 2020 13:04:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:43124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733015AbgCCR7n (ORCPT ); Tue, 3 Mar 2020 12:59:43 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D69F20870; Tue, 3 Mar 2020 17:59:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583258382; bh=99EtiNtJdAvPT2as60AJ2VmPObSheEPp0q5rtgVAgns=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U7ght9guWA5K/checuZ4CWV4nG6nPDL0gdtV3M4JJJXJckkq2xc9UZgF4B8tTCjoJ YEw9HO8esXApwrVriTRzh4mzfzm0uLa/kH5pBX4wtG4cHOlq8TMEaboia1OcjtP0QK tBXKW9pRFP70ziMy3AMrxWX33lq8LLOx/5YvgJtc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jeff Moyer , Christoph Hellwig , Jan Kara , Dan Williams , Sasha Levin Subject: [PATCH 4.19 06/87] dax: pass NOWAIT flag to iomap_apply Date: Tue, 3 Mar 2020 18:42:57 +0100 Message-Id: <20200303174349.560203639@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200303174349.075101355@linuxfoundation.org> References: <20200303174349.075101355@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeff Moyer [ Upstream commit 96222d53842dfe54869ec4e1b9d4856daf9105a2 ] fstests generic/471 reports a failure when run with MOUNT_OPTIONS="-o dax". The reason is that the initial pwrite to an empty file with the RWF_NOWAIT flag set does not return -EAGAIN. It turns out that dax_iomap_rw doesn't pass that flag through to iomap_apply. With this patch applied, generic/471 passes for me. Signed-off-by: Jeff Moyer Reviewed-by: Christoph Hellwig Reviewed-by: Jan Kara Link: https://lore.kernel.org/r/x49r1z86e1d.fsf@segfault.boston.devel.redhat.com Signed-off-by: Dan Williams Signed-off-by: Sasha Levin --- fs/dax.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/dax.c b/fs/dax.c index f0d932fa39c20..d09701aa6f2f4 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -1301,6 +1301,9 @@ dax_iomap_rw(struct kiocb *iocb, struct iov_iter *iter, lockdep_assert_held(&inode->i_rwsem); } + if (iocb->ki_flags & IOCB_NOWAIT) + flags |= IOMAP_NOWAIT; + while (iov_iter_count(iter)) { ret = iomap_apply(inode, pos, iov_iter_count(iter), flags, ops, iter, dax_iomap_actor); -- 2.20.1