Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 3 Mar 2020 09:50:51 -0800
From:   Martin KaFai Lau <kafai@fb.com>
To:     Lorenz Bauer <lmb@cloudflare.com>
CC:     <john.fastabend@gmail.com>, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jakub Sitnicki <jakub@cloudflare.com>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        <kernel-team@cloudflare.com>, <netdev@vger.kernel.org>,
        <bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 3/9] bpf: sockmap: move generic sockmap hooks
 from BPF TCP
Message-ID: <20200303175051.zcxmo3c257pfpj7f@kafai-mbp>
References: <20200228115344.17742-1-lmb@cloudflare.com>
 <20200228115344.17742-4-lmb@cloudflare.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200228115344.17742-4-lmb@cloudflare.com>
User-Agent: NeoMutt/20180716
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kafai-mbp (2620:10d:c090:500::7:521b) by MWHPR21CA0033.namprd21.prod.outlook.com (2603:10b6:300:129::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.2 via Frontend Transport; Tue, 3 Mar 2020 17:50:58 +0000
X-Originating-IP: [2620:10d:c090:500::7:521b]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 7ba4bb87-883b-4550-bc80-08d7bf9b6ec9
X-MS-TrafficTypeDiagnostic: BYAPR15MB2454:
X-Microsoft-Antispam-PRVS: <BYAPR15MB2454AC50E20335088945E9DFD5E40@BYAPR15MB2454.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:6108;
X-Forefront-PRVS: 03319F6FEF
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(346002)(366004)(39860400002)(376002)(396003)(136003)(199004)(189003)(4326008)(5660300002)(1076003)(8676002)(81156014)(4744005)(81166006)(7416002)(2906002)(478600001)(186003)(66946007)(66476007)(66556008)(6916009)(16526019)(9686003)(6496006)(55016002)(52116002)(316002)(33716001)(86362001)(8936002)(54906003)(6666004)(41533002);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR15MB2454;H:BYAPR15MB2278.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
Received-SPF: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kiX9OfwZfrDhQteOm5OO+r/+eHbCZ7UY7eq3w5zK5tLFTPYuXOW+aOmIP0kQABtUGtpMFP1cT3OwdhXBYDAUnx5mrtKncjm1qaXgbMkPF9kJ2k9pM9Z8L3Mnd8JR+y1fDTkJSJsadB87emLHFvfVmF2m6ABJUY/1bt6WKikTOQm6+AVra47oQfQgNgwHLVJGIYPwgxyts+cAvaPJvH5qcGMAWN7U9i3VBuUffNnisd/2LJyo1r52gRbK1slvYuZdJowi0GHog2OMcsgN8EbxjH+Qr7LabyFIKqlZSxCFF1pAeei/c9lt9/Itc8+rx6ul69dHtdADYEG1lpvheIkSr8ik4+lmYnBvFEtDySwI8faCTqRCltFN3YZetH2Ev3deIEPkzrpPUpLtUJ9kAyRUO2NefUN5goOlSB4OKyM+Eaj46oEdj4MjRBk8zlJWcvkAf2CGpZZusCH4AGnAwEfcm1dFJKKCFL1aC7Sa9yD2FG0dmofB5RTWSSr0kUegQ/Ux
X-MS-Exchange-AntiSpam-MessageData: TuiYMCZFYeNrDfsbOreHNk7FusIZ9n4Fz7I/85F7PYHi9gHrQVqHPClx5ekIzeDunIcrhdSCejiVlb+WgX3ywB+15pzJqeax+b5d2qgQ8iYf3zBNcp+FF9uf23mSNCDmS0fq/M77a19cn/mAON9RurGnqyP42YwlMpjrjQEPxVk2iM8DxXoaWDFPyU1OxvvP
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ba4bb87-883b-4550-bc80-08d7bf9b6ec9
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2020 17:50:59.8723
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bT2kLkJpFFf6/jGbEHmbitOiuyUFAoXRA1YWqc0ZAMeaXOESHGzX8KIssPKRKdwA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2454
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572
 definitions=2020-03-03_06:2020-03-03,2020-03-03 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 bulkscore=0
 impostorscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0
 malwarescore=0 phishscore=0 clxscore=1011 mlxlogscore=853 suspectscore=0
 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2001150001 definitions=main-2003030120
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 28, 2020 at 11:53:38AM +0000, Lorenz Bauer wrote:
> The close, unhash and clone handlers from TCP sockmap are actually generic,
> and can be reused by UDP sockmap. Move the helpers into the sockmap code
Is clone reused in UDP? 

> base and expose them. This requires tcp_bpf_(re)init and tcp_bpf_clone to
> be conditional on BPF_STREAM_PARSER.
> 

[ ... ]

> @@ -707,3 +659,4 @@ void tcp_bpf_clone(const struct sock *sk, struct sock *newsk)
>  	if (prot == &tcp_bpf_prots[family][TCP_BPF_BASE])
>  		newsk->sk_prot = sk->sk_prot_creator;
>  }
> +#endif /* CONFIG_BPF_STREAM_PARSER */
>