Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 3 Mar 2020 22:11:26 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     Stefan Berger <stefanb@linux.ibm.com>
Cc:     Stefan Berger <stefanb@linux.vnet.ibm.com>,
        linux-integrity@vger.kernel.org, aik@ozlabs.ru,
        david@gibson.dropbear.id.au, linux-kernel@vger.kernel.org,
        nayna@linux.vnet.ibm.com, gcwilson@linux.ibm.com, jgg@ziepe.ca
Subject: Re: [PATCH v5 3/3] tpm: ibmvtpm: Add support for TPM 2
Message-ID: <20200303201104.GG5775@linux.intel.com>
References: <20200228030330.18081-1-stefanb@linux.vnet.ibm.com>
 <20200228030330.18081-4-stefanb@linux.vnet.ibm.com>
 <20200302111514.GC3979@linux.intel.com>
 <2f8a9519-c1ab-8d46-18c4-4e0f9d53e3ff@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2f8a9519-c1ab-8d46-18c4-4e0f9d53e3ff@linux.ibm.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 02, 2020 at 11:21:27AM -0500, Stefan Berger wrote:
> On 3/2/20 6:15 AM, Jarkko Sakkinen wrote:
> > On Thu, Feb 27, 2020 at 10:03:30PM -0500, Stefan Berger wrote:
> > > From: Stefan Berger <stefanb@linux.ibm.com>
> > > 
> > > Support TPM 2 in the IBM vTPM driver. The hypervisor tells us what
> > > version of TPM is connected through the vio_device_id.
> > I'd prefer "TPM2" over "TPM 2".
> Fixed.
> > 
> > > In case a TPM 2 is found, we set the TPM_CHIP_FLAG_TPM2 flag
> > > and get the command codes attributes table. The driver does
> > > not need the timeouts and durations, though.
> > A TPM2 what? TPM2 is not a thing.
> 
> 
> I don't know what you mean? Is it the word 'found' and it should be
> 'present' ? Otherwise a TPM2 is a 'thing' / object / device, at least to me.

TPM2 chip would be better. TPM2 can refer either to the protocol or to a
chip.

/Jarkko