Date: Tue, 14 Feb 2006 20:45:22 +0100
From: Christoph Hellwig <hch@lst.de>
To: linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pcmcia: use kthread_ API
Message-ID: <20060214194522.GA21385@lst.de>
References: <20060214175016.GA19080@lst.de> <20060214193713.GA9435@flint.arm.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060214193713.GA9435@flint.arm.linux.org.uk>
User-Agent: Mutt/1.3.28i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 871
Lines: 18

On Tue, Feb 14, 2006 at 07:37:13PM +0000, Russell King wrote:
> On Tue, Feb 14, 2006 at 06:50:16PM +0100, Christoph Hellwig wrote:
> > Use the kthread_ API instead of opencoding lots of hairy code for kernel
> > thread creation and teardown.
> > 
> > Also use wake_up_process instead of an additional per-socket waitqueue.
> 
> Nack.  This breaks an error path - look at what happens when we fail to
> register a socket - we set socket->thread to NULL and exit.   That is
> then picked up by the "socket thread for socket %p did not start" code
> which you decided to remove.

Yes, you're right.  Let's drop the patch for now.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/