Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200213164146.366251-1-daniel.thompson@linaro.org>
In-Reply-To: <20200213164146.366251-1-daniel.thompson@linaro.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Tue, 3 Mar 2020 12:51:08 -0800
Message-ID: <CAD=FV=UM6eePrTE9Kpc4zfTSBpQSYXJghVP9dGAvD_25=JTfzw@mail.gmail.com>
Subject: Re: [PATCH] kdb: Censor attempts to set PROMPT without ENABLE_MEM_READ
To:     Daniel Thompson <daniel.thompson@linaro.org>
Cc:     Jason Wessel <jason.wessel@windriver.com>,
        kgdb-bugreport@lists.sourceforge.net,
        LKML <linux-kernel@vger.kernel.org>,
        Patch Tracking <patches@linaro.org>,
        Wang Xiayang <xywang.sjtu@sjtu.edu.cn>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Thu, Feb 13, 2020 at 8:42 AM Daniel Thompson
<daniel.thompson@linaro.org> wrote:
>
> Currently the PROMPT variable could be abused to provoke the printf()
> machinery to read outside the current stack frame. Normally this
> doesn't matter becaues md is already a much better tool for reading
> from memory.
>
> However the md command can be disabled by not setting KDB_ENABLE_MEM_READ.
> Let's also prevent PROMPT from being modified in these circumstances.
>
> Whilst adding a comment to help future code reviewers we also remove
> the #ifdef where PROMPT in consumed. There is no problem passing an
> unused (0) to snprintf when !CONFIG_SMP.
> argument
>
> Reported-by: Wang Xiayang <xywang.sjtu@sjtu.edu.cn>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
>  kernel/debug/kdb/kdb_main.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

I can't say I'm an expert on the kdb permissions model since I wasn't
really even aware of it before reading this patch, but your change
seems reasonable to me.

Reviewed-by: Douglas Anderson <dianders@chromium.org>