Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp3859494ybf; Tue, 3 Mar 2020 14:24:12 -0800 (PST) X-Google-Smtp-Source: ADFU+vtfKNVf0h7kYOgPdM/YDy82PAuhbOhqIXT+jkLXf15nMCgUAud3C1bBRjWmTOfTCbbh6/S+ X-Received: by 2002:a05:6830:110:: with SMTP id i16mr54595otp.189.1583274252144; Tue, 03 Mar 2020 14:24:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583274252; cv=none; d=google.com; s=arc-20160816; b=EVq0DWE1euwiSIfb0QtbqXlf36XdDWL3SQu2v6wKM3Pa8sTjzDxGfOG6sZcHAU2VXa bAeo0sP7L6DqxsvriiDJ5RijZwaPCqppMwb9zjM7L2Q6UCfNFU66EPeuIiTdE5qti0Wz Jdm/LOb/wTojpUjVTYjkfR5dqhzBsO05v+7t+lQ3RhckmC377Xwl8YBKcDpzb5E75HOK cazYBHYV4qQnWMf7oLZ68GnrdU/W7vdc5umTjdbOA/qTDev/yR8W/XJZb8ZSieIjl209 ubIlbYb52xXw3zBExlVLjd0V1WgRtL83L2ABeYs5BG3tsq2Mls6QoQLMkYGq2V74M9Ba qUtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=3sx1vwQWdvQ5Z2ZWTgaCbJGjCVKxUP31T5G8RYrSA9g=; b=prUgSggL/XSonkePvZGnl3T9lo3ovoyk7zt43oMOsvvbEJBXLjawOgrb7eI5zEujSp 8t0SWHo3gL0AVBLwDdPJ5/E0YcRcgWwS33XPND23eTFO/cmCTglHxaQhKNRJl5CINwu3 e9y9viaFrVqD0qacdq8SUBdL1gTHMRMCMB571mB1sYPvNU20DcxZyUlZhlb3oSfB6UR+ VOz6oUI1aUrVuQIj33kYKyEBkR+z2zoIRyFMOfz7lvr6OSQgt4ROlUVLAuw5hJU7cnkH pFYL1r7/TEs4bkuPiKSCv3btBCHoIm4Rw/5YAH+FB/3B+lFigHyF0ZtJMzAedRyX8VUV Rkew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Toq8GFkz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f187si62065oia.218.2020.03.03.14.23.59; Tue, 03 Mar 2020 14:24:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Toq8GFkz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727854AbgCCWXr (ORCPT + 99 others); Tue, 3 Mar 2020 17:23:47 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:48846 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727322AbgCCWXr (ORCPT ); Tue, 3 Mar 2020 17:23:47 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 023MI9eM056809; Tue, 3 Mar 2020 22:23:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2020-01-29; bh=3sx1vwQWdvQ5Z2ZWTgaCbJGjCVKxUP31T5G8RYrSA9g=; b=Toq8GFkzL372Owc/4KN1qQbRsT9j4MDSzCv9DVNQ1BDhKCkrhlXEoeQNWcL8jYUXfSZ8 PNS2A5dl3BLgMybeoowg+PeSbKIBT3oxiBCsNxOZXnKES3Eq3ULEGx+xSVJPXMlQWrEB W+/TKgtCKe+AeWCq7HzxIh9ePVU+LuotI8j2xtibJr9iU8JES4mGjYcq1RNtb1pYpe8r Nn82JmhooPdWYK7sWCs07dbUFIdeL8zdqm3F8pJfUTLtg4f/cm+cL41FZcimv2xCNDaa qtBVzmCP2LCT8fGaJIaFIQ57+mzY9QfyCEc4BXTH4KLxOlTR8MGCV3qmbAINGIAut5/0 ZQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2yffwqtb56-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Mar 2020 22:23:40 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 023MMU2l141297; Tue, 3 Mar 2020 22:23:39 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2yg1p5kbdf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Mar 2020 22:23:39 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 023MNbrI031000; Tue, 3 Mar 2020 22:23:38 GMT Received: from localhost.localdomain (/10.211.9.80) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 03 Mar 2020 14:23:37 -0800 From: Dongli Zhang To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Cc: julien@xen.org, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, joe.jin@oracle.com Subject: [PATCH v3 2/2] xenbus: req->err should be updated before req->state Date: Tue, 3 Mar 2020 14:14:23 -0800 Message-Id: <20200303221423.21962-2-dongli.zhang@oracle.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200303221423.21962-1-dongli.zhang@oracle.com> References: <20200303221423.21962-1-dongli.zhang@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9549 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 mlxlogscore=980 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003030144 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9549 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 spamscore=0 impostorscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 phishscore=0 clxscore=1015 bulkscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003030143 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds the barrier to guarantee that req->err is always updated before req->state. Otherwise, read_reply() would not return ERR_PTR(req->err) but req->body, when process_writes()->xb_write() is failed. Signed-off-by: Dongli Zhang --- drivers/xen/xenbus/xenbus_comms.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/xen/xenbus/xenbus_comms.c b/drivers/xen/xenbus/xenbus_comms.c index 852ed161fc2a..eb5151fc8efa 100644 --- a/drivers/xen/xenbus/xenbus_comms.c +++ b/drivers/xen/xenbus/xenbus_comms.c @@ -397,6 +397,8 @@ static int process_writes(void) if (state.req->state == xb_req_state_aborted) kfree(state.req); else { + /* write err, then update state */ + virt_wmb(); state.req->state = xb_req_state_got_reply; wake_up(&state.req->wq); } -- 2.17.1