Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.60.83 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01;
Subject: Re: [PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver optional
To:     Sudeep Holla <sudeep.holla@arm.com>,
        Jolly Shah <jolly.shah@xilinx.com>
Cc:     ard.biesheuvel@linaro.org, mingo@kernel.org,
        gregkh@linuxfoundation.org, matt@codeblueprint.co.uk,
        hkallweit1@gmail.com, keescook@chromium.org,
        dmitry.torokhov@gmail.com, michal.simek@xilinx.com,
        rajanv@xilinx.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Tejas Patel <tejas.patel@xilinx.com>
References: <1582675460-26914-1-git-send-email-jolly.shah@xilinx.com>
 <20200226114601.GB8613@bogus>
From:   Jolly Shah <jolly.shah@xilinx.com>
Message-ID: <8aed558b-6ff8-5c7c-626e-17f982b12682@xilinx.com>
Date:   Tue, 3 Mar 2020 14:29:57 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200226114601.GB8613@bogus>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2020 22:30:14.5880
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c1db971c-dbc6-42fb-b335-08d7bfc2719e
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB5181
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sudeep,

 > ------Original Message------
 > From: Sudeep.holla@arm.com <sudeep.holla@arm.com>
 > Sent:  Wednesday, February 26, 2020 3:46AM
 > To: Jolly Shah <jolly.shah@xilinx.com>
 > Cc: Ard.biesheuvel@linaro.org <ard.biesheuvel@linaro.org>, 
Mingo@kernel.org <mingo@kernel.org>, 'Greg Kh' 
<gregkh@linuxfoundation.org>, Matt@codeblueprint.co.uk 
<matt@codeblueprint.co.uk>, Hkallweit1@gmail.com <hkallweit1@gmail.com>, 
Keescook@chromium.org <keescook@chromium.org>, Dmitry.torokhov@gmail.com 
<dmitry.torokhov@gmail.com>, Michal Simek <michal.simek@xilinx.com>, 
Rajan Vaja <rajanv@xilinx.com>, Linux-arm-kernel@lists.infradead.org 
<linux-arm-kernel@lists.infradead.org>, Linux-kernel@vger.kernel.org 
<linux-kernel@vger.kernel.org>, Tejas Patel <tejas.patel@xilinx.com>, 
Sudeep.holla@arm.com <sudeep.holla@arm.com>
 > Subject: Re: [PATCH] arch: arm64: xilinx: Make zynqmp_firmware driver 
optional
 >
> On Tue, Feb 25, 2020 at 04:04:20PM -0800, Jolly Shah wrote:
>> From: Tejas Patel <tejas.patel@xilinx.com>
>>
>> Make zynqmp_firmware driver as optional to disable it, if user don't
>> want to use default zynqmp firmware interface.
>>
> 
> This patch on it own is simple and looks fine. However I expect the
> single binary to work with and without this option on the same platform.
> If zynqmp_firmware is not critical, the system should continue to work
> fine either way. The zynqmp_firmware driver should gracefully exit with
> error(if any).
> 

Sure. Will address it in next version.

Thanks,
Jolly Shah


> --
> Regards,
> Sudeep
>