Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 4 Mar 2020 07:07:11 +0530
From:   afzal mohammed <afzal.mohd.ma@gmail.com>
To:     Greg Ungerer <gerg@linux-m68k.org>
Cc:     linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Finn Thain <fthain@telegraphics.com.au>
Subject: Re: [PATCH v5] m68k: Replace setup_irq() by request_irq()
Message-ID: <20200304013711.GA5470@afzalpc>
References: <20200229153406.GA32479@afzalpc>
 <20200301012655.GA6035@afzalpc>
 <c2c04a29-4fc8-7cb5-6cc6-5bc3b125d047@linux-m68k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c2c04a29-4fc8-7cb5-6cc6-5bc3b125d047@linux-m68k.org>
User-Agent: Mutt/1.9.3 (2018-01-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Greg,

On Mon, Mar 02, 2020 at 11:32:53AM +1000, Greg Ungerer wrote:

> I have retested and everything works as expected, so:
> 
>   Tested-by: Greg Ungerer <gerg@linux-m68k.org>
> 
> I have applied this to the m68knommu git tree, for next branch.

Thanks

> >   void hw_timer_init(irq_handler_t handler)
> >   {
> > +	int r;
> 
> You used 'r' here as the error return value holder.
> But in the previous cases you used 'ret'.
> I would have used the same name everywhere ('ret' probably being the
> most commonly used in the kernel).

That was a circus to dodge 80 char limit, i did think about it while
making the changes whether to do or not. If 'ret' is used request_irq()
line had to be split to two, slightly affecting the readability and
since 'r' was a local variable (though conventionally 'ret' or 'err'
is used) went ahead that way. Even if 're' is used as the local
variable, it would be 81 chars ;)

Let me know if you want to change it.

Regards
afzal

> > -	setup_irq(MCF_IRQ_TIMER, &mcfslt_timer_irq);
> > +	r = request_irq(MCF_IRQ_TIMER, mcfslt_tick, IRQF_TIMER, "timer", NULL);
> > +	if (r) {
> > +		pr_err("Failed to request irq %d (timer): %pe\n", MCF_IRQ_TIMER,
> > +		       ERR_PTR(r));
> > +	}