Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mm/hugetlb.c: Clean code by removing unnecessary
 initialization
To:     mateusznosek0@gmail.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Cc:     akpm@linux-foundation.org
References: <20200303212354.25226-1-mateusznosek0@gmail.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
Message-ID: <87d405de-d73b-9ba9-1644-c2222881ed98@oracle.com>
Date:   Tue, 3 Mar 2020 18:20:47 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200303212354.25226-1-mateusznosek0@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/3/20 1:23 PM, mateusznosek0@gmail.com wrote:
> From: Mateusz Nosek <mateusznosek0@gmail.com>
> 
> Previously variable 'check_addr' was initialized,
> but was not read later before reassigning.
> So the initialization can be removed.
> 
> Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>

Thanks, that is indeed not needed.
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz

> ---
>  mm/hugetlb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index e4116385a4e1..7fb31750e670 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -5021,7 +5021,7 @@ static bool vma_shareable(struct vm_area_struct *vma, unsigned long addr)
>  void adjust_range_if_pmd_sharing_possible(struct vm_area_struct *vma,
>  				unsigned long *start, unsigned long *end)
>  {
> -	unsigned long check_addr = *start;
> +	unsigned long check_addr;
>  
>  	if (!(vma->vm_flags & VM_MAYSHARE))
>  		return;
>